Opened 13 years ago
Closed 13 years ago
#6950 closed enhancement (fixed)
[with patch, positive review] computing algebraic immunity
Reported by: | ylchapuy | Owned by: | somebody |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.1.2 |
Component: | cryptography | Keywords: | |
Cc: | malb | Merged in: | Sage 4.1.2.alpha2 |
Authors: | Yann Laigle-Chapuy | Reviewers: | Martin Albrecht |
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
It would be nice to have an efficient implementation for computing the algebraic immunity of a Boolean function and finding annihilators.
Attachments (1)
Change History (8)
comment:1 Changed 13 years ago by
- Cc malb added
- Priority changed from major to minor
- Summary changed from computing algebraic immunity to [with patch, needs review] computing algebraic immunity
comment:2 Changed 13 years ago by
Of course, its okay :) I'll try to do the review before I go on holiday on Saturday.
comment:3 Changed 13 years ago by
I noticed def random_BooleanFunction(n)
while skimming the patch, the convention seems to be random_boolean_function
, i.e. lower case for functions.
comment:4 Changed 13 years ago by
Patch updated.
comment:5 Changed 13 years ago by
Review
- patch applies cleanly against alpha1
- you shouldn't need
#random
in the doctest because the random seed should be reset before each doctest to make sure that the result is reproducible. - there are some very minor line break problems in the HTML reference manual: http://sage.math.washington.edu/home/malb/scratch/sage-4.1.2.alpha1/devel/sage/doc/output/html/en/reference/sage/crypto/boolean_function.html
- also
..math::
is not properly typesetted (cf. same link) - doctests pass on sage.math
So almost positive review, module the nitpicks above. Feel free to change it to a positive review once those are addressed.
comment:6 Changed 13 years ago by
- Reviewers set to Martin Albrecht
- Summary changed from [with patch, needs review] computing algebraic immunity to [with patch, positive review] computing algebraic immunity
Thanks for that quick review, and enjoy your holidays!
comment:7 Changed 13 years ago by
- Merged in set to Sage 4.1.2.alpha2
- Resolution set to fixed
- Status changed from new to closed
See #6953 for a follow-up to this ticket.
This is a toy implementation, but still better than nothing. I also added a way of constructing a random Boolean function, I hope it's ok to put both in this ticket.
PS: Is it ok if I cc you Martin?