Opened 11 years ago

Closed 11 years ago

#6916 closed defect (fixed)

[with patch, positive review] follow-up to #6749: fix warnings when building reference manual

Reported by: mvngu Owned by: tba
Priority: major Milestone: sage-4.1.2
Component: documentation Keywords:
Cc: ncohen Merged in: Sage 4.1.2.rc0
Authors: Minh Van Nguyen Reviewers: William Stein, John Palmieri
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

As the subject says. This is a follow-up to ticket #6749.

Attachments (1)

trac_6916-typos.patch (10.6 KB) - added by mvngu 11 years ago.
based on Sage 4.1.2.alpha4

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by mvngu

  • Authors set to Minh Van Nguyen
  • Cc ncohen added
  • Component changed from algebra to documentation
  • Milestone set to sage-4.1.2
  • Owner changed from tbd to tba
  • Summary changed from follow-up to #6749: fix warnings when building reference manual to [with patch, needs review] follow-up to #6749: fix warnings when building reference manual

comment:2 Changed 11 years ago by was

  • Summary changed from [with patch, needs review] follow-up to #6749: fix warnings when building reference manual to [with patch, positive review] follow-up to #6749: fix warnings when building reference manual

comment:3 follow-up: Changed 11 years ago by jhpalmieri

  • Reviewers set to William Stein, John Palmieri

I give it a positive review, too, but if you want to change the lines

    - ``seq`` -- Two different possible types: 
      - A sequence of pairs (weight, value). 
      - A sequence of reals (a value of 1 is assumed). 

by adding a blank line after the first one, it looks a little better (to me) when typeset. I'll give that a positive review in advance, so if you want to make the change, no need for more review.

Changed 11 years ago by mvngu

based on Sage 4.1.2.alpha4

comment:4 in reply to: ↑ 3 Changed 11 years ago by mvngu

Replying to jhpalmieri:

I give it a positive review, too, but if you want to change the lines

    - ``seq`` -- Two different possible types: 
      - A sequence of pairs (weight, value). 
      - A sequence of reals (a value of 1 is assumed). 

by adding a blank line after the first one, it looks a little better (to me) when typeset.

Done.

comment:5 Changed 11 years ago by mvngu

  • Merged in set to Sage 4.1.2.rc0
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.