Opened 12 years ago

Closed 12 years ago

#6911 closed enhancement (fixed)

[with patch, positive review] Faster basis and discriminants of a Hecke algebra

Reported by: robertwb Owned by: craigcitro
Priority: major Milestone: sage-4.1.2
Component: modular forms Keywords:
Cc: Merged in: Sage 4.1.2.alpha2
Authors: Robert Bradshaw Reviewers: William Stein
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Attachments (3)

Change History (9)

comment:1 Changed 12 years ago by robertwb

Also discriminants.

Changed 12 years ago by robertwb

comment:2 Changed 12 years ago by robertwb

  • Summary changed from Faster basis of a Hecke algebra to [with patch, needs review] Faster basis of a Hecke algebra

comment:3 Changed 12 years ago by was

  • Summary changed from [with patch, needs review] Faster basis of a Hecke algebra to [with patch, needs work] Faster basis of a Hecke algebra

REFEREE REPORT:

  1. Awesome trace of product trick!
  1. I think the following range must start at 1 -- otherwise this is potentially (in theory) a major bug:
    span = [self.hecke_operator(n) for n in range(2, bound+1) if not self.is_anemic() or gcd(n, level) == 1] 
    
  1. "eisenstein" should be capitalized below:
     	1182	        Returns whether self is cuspidal, i.e. has no eisenstein part.
    
  1. The patch doesn't seem to apply cleanly to 4.1.2.alpha1:
    Hunk #4 FAILED at 214
    1 out of 6 hunks FAILED -- saving rejects to file sage/modular/hecke/algebra.py.rej
    abort: patch failed to apply
    

comment:4 Changed 12 years ago by was

  • Summary changed from [with patch, needs work] Faster basis of a Hecke algebra to [with patch, positive review] Faster basis and discriminants of a Hecke algebra

comment:5 Changed 12 years ago by was

Apply these:

trac_6911-referee-replace_other_patch-apply_only_this.patch
trac_6911-referee_followup_that_fixes_some_bugs.patch 

comment:6 Changed 12 years ago by mvngu

  • Authors set to Robert Bradshaw
  • Merged in set to Sage 4.1.2.alpha2
  • Resolution set to fixed
  • Reviewers set to William Stein
  • Status changed from new to closed

Merged patches in this order:

  1. trac_6911-referee-replace_other_patch-apply_only_this.patch
  2. trac_6911-referee_followup_that_fixes_some_bugs.patch
Note: See TracTickets for help on using tickets.