Opened 12 years ago
Closed 12 years ago
#6911 closed enhancement (fixed)
[with patch, positive review] Faster basis and discriminants of a Hecke algebra
Reported by: | robertwb | Owned by: | craigcitro |
---|---|---|---|
Priority: | major | Milestone: | sage-4.1.2 |
Component: | modular forms | Keywords: | |
Cc: | Merged in: | Sage 4.1.2.alpha2 | |
Authors: | Robert Bradshaw | Reviewers: | William Stein |
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Followup to #6768, uses algorithm at http://wiki.sagemath.org/days17/projects/presagedays/discussion
Attachments (3)
Change History (9)
comment:1 Changed 12 years ago by
Changed 12 years ago by
comment:2 Changed 12 years ago by
- Summary changed from Faster basis of a Hecke algebra to [with patch, needs review] Faster basis of a Hecke algebra
comment:3 Changed 12 years ago by
- Summary changed from [with patch, needs review] Faster basis of a Hecke algebra to [with patch, needs work] Faster basis of a Hecke algebra
REFEREE REPORT:
- Awesome trace of product trick!
- I think the following range must start at 1 -- otherwise this is potentially (in theory) a major bug:
span = [self.hecke_operator(n) for n in range(2, bound+1) if not self.is_anemic() or gcd(n, level) == 1]
- "eisenstein" should be capitalized below:
1182 Returns whether self is cuspidal, i.e. has no eisenstein part.
- The patch doesn't seem to apply cleanly to 4.1.2.alpha1:
Hunk #4 FAILED at 214 1 out of 6 hunks FAILED -- saving rejects to file sage/modular/hecke/algebra.py.rej abort: patch failed to apply
comment:4 Changed 12 years ago by
- Summary changed from [with patch, needs work] Faster basis of a Hecke algebra to [with patch, positive review] Faster basis and discriminants of a Hecke algebra
Changed 12 years ago by
Changed 12 years ago by
comment:5 Changed 12 years ago by
Apply these:
trac_6911-referee-replace_other_patch-apply_only_this.patch trac_6911-referee_followup_that_fixes_some_bugs.patch
comment:6 Changed 12 years ago by
- Merged in set to Sage 4.1.2.alpha2
- Resolution set to fixed
- Reviewers set to William Stein
- Status changed from new to closed
Merged patches in this order:
trac_6911-referee-replace_other_patch-apply_only_this.patch
trac_6911-referee_followup_that_fixes_some_bugs.patch
Note: See
TracTickets for help on using
tickets.
Also discriminants.