Opened 12 years ago
Closed 12 years ago
#6858 closed defect (fixed)
[with patch, positive review] Cayley graph connecting set
Reported by: | rlm | Owned by: | rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-4.1.2 |
Component: | graph theory | Keywords: | |
Cc: | Merged in: | Sage 4.1.2.alpha2 | |
Authors: | Robert Miller | Reviewers: | Nathann Cohen |
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Reported by Chris Godsil.
Attachments (1)
Change History (6)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
- Summary changed from [with patch, needs review] Cayley graph connecting set to [with patch, needs work] Cayley graph connecting set
Changed 12 years ago by
comment:3 Changed 12 years ago by
- Summary changed from [with patch, needs work] Cayley graph connecting set to [with patch, needs review] Cayley graph connecting set
OK, this new patch should do the trick.
comment:4 Changed 12 years ago by
- Summary changed from [with patch, needs review] Cayley graph connecting set to [with patch, positive review] Cayley graph connecting set
Applies fine, documented,does its job.... Positive review ! ;-)
When testing the patch, I tried ( among others ) :
sage: len(g.cayley_graph(connecting_set=[(1,2)]).connected_components()) 60 sage: len(g.cayley_graph(connecting_set=[(1,2),(2,3)]).connected_components()) 20 sage: len(g.cayley_graph(connecting_set=[(1,2),(2,3),(3,4)]).connected_components()) 5
If you think it useful, it could also be included in the examples contained in the docstring, even though there are already two and it may not be necessary at all :-)
Nathann
comment:5 Changed 12 years ago by
- Merged in set to Sage 4.1.2.alpha2
- Resolution set to fixed
- Reviewers set to Nathann Cohen
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Hmmm.. I may have done something wrong, but here is what I tried
Even though it's apparent I know very few about groups in Sage as I had to build S_n by enumerating generators ( I guess there is a command to do that with only the cardinal ? ) ^{};