Opened 11 years ago

Closed 11 years ago

#6856 closed defect (fixed)

[with patch, positive review] cancel button in notebook user settings not working

Reported by: wjp Owned by: boothby
Priority: major Milestone: sage-4.1.2
Component: notebook Keywords:
Cc: Merged in: Sage 4.1.2.alpha0
Authors: Willem Jan Palenstijn Reviewers: Dan Drake
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The cancel button in the 'Settings' page of a notebook user is not working because of a missing 'username' template argument to account_settings.html. (There's a redirect to a broken path when pressing the button now.)

Attachments (1)

trac_6856-fix_account_settings_cancel.patch (931 bytes) - added by wjp 11 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by wjp

  • Summary changed from cancel button in notebook user settings not working to [with patch, needs review] cancel button in notebook user settings not working

comment:2 Changed 11 years ago by wjp

To reproduce, log in to the notebook, press 'Settings' at the top right, and then press 'Cancel'.

comment:3 Changed 11 years ago by ddrake

  • Authors set to Willem Jan Palenstijn
  • Reviewers set to Dan Drake
  • Summary changed from [with patch, needs review] cancel button in notebook user settings not working to [with patch, positive review] cancel button in notebook user settings not working

A one-line patch that fixes the problem! Positive review.

comment:4 Changed 11 years ago by mvngu

  • Merged in set to Sage 4.1.2.alpha0
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.