Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#6829 closed enhancement (fixed)

[with patch, positive review] Implement Manin symbols over number fields

Reported by: cremona Owned by: craigcitro
Priority: major Milestone: sage-4.1.2
Component: modular forms Keywords: modular manin symbols
Cc: mtaranes Merged in: Sage 4.1.2.alpha4
Authors: Maite Aranes Reviewers: Georg S. Weber
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Manin symbols over number fields (related to modular symbols) are used for computing modular forms over those fields. An implementation valid for general number fields is in prepration by Maite Aranes.

This will be part of a larger project to implement modular forms over number fields in Sage.

Attachments (1)

p1list_nf.patch (37.5 KB) - added by mtaranes 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by mtaranes

comment:1 Changed 10 years ago by mtaranes

  • Summary changed from Implement Manin symbols over number fields to [with patch, needs review] Implement Manin symbols over number fields

comment:2 Changed 10 years ago by mtaranes

The patch is based on 4.1.1

comment:3 Changed 10 years ago by GeorgSWeber

  • Summary changed from [with patch, needs review] Implement Manin symbols over number fields to [with patch, positive review] Implement Manin symbols over number fields

Just my two cents.

Mathematically: Both the normalization (lines 415 - 455) and the list creation (lines 993 - 1018) look good to me, forming the heart of the module. Index-looking up is done by list searching, well. The other internal functions lift_to_sl2_Ok, make_coprime, psi also look good.

Non-mathematically: This is how more Sage library code should look like. If this applies cleanly to the newest Sage alpha, doctests all pass and have 100% coverage, and the ReST documentation compiles OK (I didn't check, but I'd be surprised if there was any issue), then I'd vote to let this in.

comment:4 Changed 10 years ago by mvngu

  • Authors set to Maite Aranes
  • Merged in set to Sage 4.1.2.alpha3
  • Resolution set to fixed
  • Reviewers set to Georg S. Weber
  • Status changed from new to closed

comment:5 Changed 10 years ago by mvngu

  • Merged in changed from Sage 4.1.2.alpha3 to Sage 4.1.2.alpha4

There is no 4.1.2.alpha3. Sage 4.1.2.alpha3 was William Stein's release for working on making the notebook a standalone package.

Note: See TracTickets for help on using tickets.