Opened 10 years ago
Closed 10 years ago
#6823 closed enhancement (fixed)
[with patch, positive review] Kneser Graph in graph_generators
Reported by: | ncohen | Owned by: | rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-4.2 |
Component: | graph theory | Keywords: | graph generators kneser |
Cc: | Merged in: | sage-4.2.alpha0 | |
Authors: | Nathann Cohen | Reviewers: | Rob Beezer |
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Kneser graphs for graph_generators ( http://en.wikipedia.org/wiki/Kneser_graph )
I just define the new function graphs.KneserGraph?()
Attachments (3)
Change History (9)
Changed 10 years ago by
comment:1 Changed 10 years ago by
- Keywords graph generators kneser added
- Summary changed from [with patch, needs review] Kneser Graph in graph_generators to [with patch, needs work] Kneser Graph in graph_generators
comment:2 Changed 10 years ago by
- Summary changed from [with patch, needs work] Kneser Graph in graph_generators to [with patch, needs review] Kneser Graph in graph_generators
New patch. Odds graphs are added, and with some luck each one of your remarks will find an answer in this new version. Hope you'll like it ! :-)
Nathann
Changed 10 years ago by
comment:3 Changed 10 years ago by
New patch taking into account the comments from #6828
comment:4 Changed 10 years ago by
- Reviewers set to Rob Beezer
Nathann,
Looks very good, builds on 4.1.2.alpha2, passes all tests, etc.
Right now the name of an odd graph reports the Kneser graph parameters, etc. I'd expect this to confuse someone who builds an odd graph, yet does not know the connection to the Kneser graphs. I've attached a small patch that just sets the name on the odd graph routine. If you agree with the change, then you can mark the ticket as positive review. In other words, you can review my additional patch, and we'll be done.
Thanks, Rob
comment:5 Changed 10 years ago by
- Summary changed from [with patch, needs review] Kneser Graph in graph_generators to [with patch, positive review] Kneser Graph in graph_generators
Good thinking ! ;-)
Nathann
comment:6 Changed 10 years ago by
- Merged in set to sage-4.2.alpha0
- Resolution set to fixed
- Status changed from positive_review to closed
Hi Nathann,
This will be a nice addition to the graph generators. Some suggestions:
n >= 0
and then that0 <= k <= n
?With this completed, it'll be easy to add the Odd graphs - just Kneser graphs with n=2k+1.
This passes all tests in sage/graphs and the documentation builds fine.
Rob