Opened 8 years ago

Closed 8 years ago

#6809 closed enhancement (fixed)

abstract_methods_of_class

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-4.2
Component: misc Keywords: abstract methods
Cc: sage-combinat Merged in: sage-4.2.alpha1
Authors: Nicolas M. Thiéry Reviewers: Florent Hivert
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Implement a utility abstract_methods_of_class which lists all the optional and mandatory abstract methods of the class.

Attachments (3)

trac_6809_abstract_methods_of_class.patch (3.4 KB) - added by nthiery 8 years ago.
trac_6809_abstract_methods_of_class.2.patch (3.9 KB) - added by hivert 8 years ago.
New version with is_optional method
trac_6809_abstract_methods_of_class.3.patch (3.9 KB) - added by hivert 8 years ago.
Added missing blank line

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by nthiery

comment:1 Changed 8 years ago by nthiery

Changed 8 years ago by hivert

New version with is_optional method

comment:2 Changed 8 years ago by hivert

  • Reviewers changed from Franco Saliola? to Florent Hivert
  • Status changed from new to needs_review

I'm done reviewing this patch. It is good upto a small detail: the code access to a private attribute. I've added an accessor method.

I just uploaded a new version of the patch after review which add a is_optional method for better encapsulation (as suggested by former comment in the code).

Nicolas: please add a positive review when you finished reviewing my changes.

Cheers,

Florent

comment:3 Changed 8 years ago by hivert

During his review of my change Nicolas spotted a missing blank line after 'EXAMPLE::'... I'm re-uploading the patch...

Cheers,

Florent

Changed 8 years ago by hivert

Added missing blank line

comment:4 Changed 8 years ago by hivert

  • Status changed from needs_review to positive_review

After Blank line added, Nicolas allows me to put the positive review.

Only apply the last trac_6809_abstract_methods_of_class.3.patch

Florent

comment:5 Changed 8 years ago by mhansen

  • Merged in set to sage-4.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.