Opened 10 years ago

Closed 10 years ago

#6780 closed enhancement (fixed)

[with patch, positive review] Stability improvement for lattice_polytope

Reported by: novoselt Owned by: mhampton
Priority: major Milestone: sage-4.2.1
Component: geometry Keywords:
Cc: Merged in:
Authors: Andrey Novoseltsev Reviewers: Marshall Hampton
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

As it was already observed before, there are problems with using LatticePolytope for polytopes with many vertices/points. The problem occurs during pipe calls to PALP for single polytopes and can be avoided using lattice_polytope.all_* functions which work with files.

This patch switches all interaction with PALP to files by default, while allowing the old method as an option.

It may affect the speed, but I cannot detect the difference on sage.math. On the other hand, in many cases I had to deal with polytopes which worked fine and fast through files and lead to hang-ups with pipes.

Attachments (1)

trac_6780_stability_improvement_for_lattice_polytope.patch (3.9 KB) - added by novoselt 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by novoselt

  • Summary changed from Stability improvement for lattice_polytope to [with patch, needs review] Stability improvement for lattice_polytope

comment:2 Changed 10 years ago by mhampton

  • Status changed from needs_review to positive_review
  • Summary changed from [with patch, needs review] Stability improvement for lattice_polytope to [with patch, positive review] Stability improvement for lattice_polytope

This passes all tests and definitely seems like an improvement. The solution does seem a little complicated, and it seems unlikely that the always_use_files(False) option will be used by anyone, but that's OK. Its always hard to say what people actually use, so leaving that in as an option is good.

comment:3 Changed 10 years ago by novoselt

This patch is included as a part of a rebased patch for #6831.

comment:4 Changed 10 years ago by mhansen

  • Authors set to Andrey Novoseltsev
  • Resolution set to fixed
  • Reviewers set to Marshall Hampton
  • Status changed from positive_review to closed

Fixed in #6831.

Note: See TracTickets for help on using tickets.