Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#6751 closed enhancement (fixed)

[with patch, positive review] implement ternary quadratic forms associated to orders in rational quaternion algebras

Reported by: was Owned by: tbd
Priority: major Milestone: sage-4.1.2
Component: algebra Keywords:
Cc: Merged in: Sage 4.1.2.alpha0
Authors: William Stein Reviewers: John Cremona
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This patch could possibly depend on #6745.

The goal of this patch is to implement computation of the ternary quadratic form associated to an order in a rational quaternion algebra. These are useful, e.g, in computing with Heegner points, in decided whether quaternion orders have embeddings from orders in quadratic imaginary fields, and in computing elements of the Kohnen + subspace of modular forms of weight 3/2.

Attachments (2)

trac_6751.patch (4.7 KB) - added by was 12 years ago.
trac_6751-review.patch (814 bytes) - added by cremona 12 years ago.
Apply after previous

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by was

comment:1 Changed 12 years ago by was

  • Summary changed from implement ternary quadratic forms associated to orders in rational quaternion algebras to [with patch; needs review] implement ternary quadratic forms associated to orders in rational quaternion algebras

Changed 12 years ago by cremona

Apply after previous

comment:2 Changed 12 years ago by cremona

Looks good to me: applies fine to 4.1.1, tests pass, some examples I tried looked correct (as does the code).

There's one small typo ("had" for "has" in the docstring) which I put into a second patch (overkill perhaps!)

comment:3 Changed 12 years ago by cremona

  • Authors set to William Stein
  • Reviewers set to John Cremona
  • Summary changed from [with patch; needs review] implement ternary quadratic forms associated to orders in rational quaternion algebras to [with patch; with positive review] implement ternary quadratic forms associated to orders in rational quaternion algebras

comment:4 Changed 12 years ago by mvngu

  • Merged in set to Sage 4.1.2.alpha0
  • Resolution set to fixed
  • Status changed from new to closed
  • Summary changed from [with patch; with positive review] implement ternary quadratic forms associated to orders in rational quaternion algebras to [with patch, with positive review] implement ternary quadratic forms associated to orders in rational quaternion algebras

Merged both patches. The patch trac_6751.patch applies OK, but with fuzz:

[mvngu@sage sage-main]$ hg qimport http://trac.sagemath.org/sage_trac/raw-attachment/ticket/6751/trac_6751.patch && hg qpush
adding trac_6751.patch to series file
applying trac_6751.patch
patching file sage/algebras/quatalg/quaternion_algebra_element.pyx
Hunk #1 succeeded at 537 with fuzz 2 (offset -76 lines).
Now at: trac_6751.patch

comment:5 Changed 12 years ago by mvngu

See #6846 for a follow up to this ticket.

comment:6 Changed 12 years ago by mvngu

  • Summary changed from [with patch, with positive review] implement ternary quadratic forms associated to orders in rational quaternion algebras to [with patch, positive review] implement ternary quadratic forms associated to orders in rational quaternion algebras
Note: See TracTickets for help on using tickets.