Opened 8 years ago

Closed 8 years ago

#6655 closed enhancement (fixed)

Cleanups and new features about corners and cells in partition and tableau

Reported by: numata Owned by: hivert
Priority: major Milestone: sage-4.4.2
Component: combinatorics Keywords: Partition cells arm legs
Cc: sage-combinat Merged in: sage-4.4.2.alpha0
Authors: Numata Yasuhide, Florent Hivert Reviewers: Anne Schilling
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by hivert)

The main goal of the patch was to add two functions namely arm_cells and leg_cells. On the way I found several bugs or inconsistencies:

Whereas the various cells methods returns the cells as tuple (i,j) Partition.corner used to return them as lists [i,j]. I changed them to return tuples. Various methods had to be fixed methods accordingly...

On the way I found that Tableaux.slide which uses Partition.Corner was modifying it's argument.

Attachments (3)

trac_6655_partition_newfeature-ny.patch (1.4 KB) - added by numata 8 years ago.
trac_6655_partition_corner_cells-fh.patch (27.9 KB) - added by hivert 8 years ago.
trac_6655_partition_corner_cells-review-as.patch (1.5 KB) - added by aschilling 8 years ago.

Download all attachments as: .zip

Change History (13)

Changed 8 years ago by numata

comment:1 Changed 8 years ago by numata

  • Summary changed from Clean up and new feature in partition to [with patch, not ready for review] Clean up and new feature in partition

comment:2 Changed 8 years ago by numata

  • Owner changed from mhansen to numata
  • Status changed from new to assigned

comment:3 Changed 8 years ago by hivert

  • Authors changed from NUMATA Yaushide to NUMATA Yasuhide, Florent Hivert
  • Description modified (diff)
  • Keywords Partition cells arm legs added; Parition removed
  • Owner changed from numata to hivert
  • Report Upstream set to N/A
  • Summary changed from [with patch, not ready for review] Clean up and new feature in partition to Cleanups and new features about corners and cells in partition and tableau

comment:4 Changed 8 years ago by hivert

  • Status changed from needs_work to needs_review

Should be ready for review ! Apply only trac_6655_partition_corner_cells-fh.patch

comment:5 Changed 8 years ago by hivert

I slightly improved the doc and re-uploaded the patch...

comment:6 Changed 8 years ago by hivert

I just discovered some failing docttests. Everything should now be ok. Please review

comment:7 follow-up: Changed 8 years ago by aschilling

  • Reviewers set to Anne Schilling

Hi Florent,

Thank you for this patch. Here are a couple of comments:

  • Please use consistently "in English convention" instead of "in english notations",

see line 840, 963, 924.

  • Would it be possible to lift the methods arm_length, leg_length, hook_length, arm_cells, etc also to SkewPartitions?? I recently needed those and it would be convenient to have them directly in Sage.

Cheers,

Anne

Changed 8 years ago by hivert

comment:8 in reply to: ↑ 7 Changed 8 years ago by hivert

  • Please use consistently "in English convention" instead of "in english notations",

see line 840, 963, 924.

Fixed...

  • Would it be possible to lift the methods arm_length, leg_length, hook_length, arm_cells, etc also to SkewPartitions?? I recently needed those and it would be convenient to have them directly in Sage.

Except for cells which I just added, they are all accessible through l.outer().arm_length... So I'm not sure we wan't to link all of those.

Changed 8 years ago by aschilling

comment:9 Changed 8 years ago by aschilling

  • Status changed from needs_review to positive_review

I reviewed the patch. It cleans up several features in partitions. In addition it fixes the slide method in skew_tableaux and adds the cell method to skew_partitions as requested. All tests pass. Positive review!

Release manager, please apply only trac_6655_partition_corner_cells-fh.patch and trac_6655_partition_corner_cells-review-as.patch (in this order).

comment:10 Changed 8 years ago by mvngu

  • Authors changed from NUMATA Yasuhide, Florent Hivert to Numata Yasuhide, Florent Hivert
  • Merged in set to sage-4.4.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.