Changes between Version 34 and Version 36 of Ticket #6637


Ignore:
Timestamp:
05/11/14 00:30:47 (6 years ago)
Author:
slabbe
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6637

    • Property Status changed from needs_work to needs_review
    • Property Commit changed from 42262457c67606ba2861e9ba7b5cb6f20450f09d to 766a1b0d7a09c8d9597308592db9543145e61751
  • Ticket #6637 – Description

    v34 v36  
    992. Deprecate `TransitiveIdeal`, `TransitiveIdealGraded` and `SearchForest` as entry point.
    1010
     113. `TransitiveIdeal(succ, seeds)` keeps the same behavior as before and is now the same as `RecursivelyEnumeratedSet(seeds, succ, structure=None, enumeration='naive')`.
     12
     134. `TransitiveIdealGraded(succ, seeds, max_depth)` keeps the same behavior as before and is now the same as `RecursivelyEnumeratedSet(seeds, succ, structure=None, enumeration='breadth', max_depth=max_depth)`.
     14
    1115Remarks:
    1216
    1317A. For now the code of `SearchForest` is still in `sage/combinat/backtrack.py`. It should be moved in `sage/sets/recursively_enumerated_set.pyx` in a later ticket.
    1418
    15 B. Note that there are some issues with `TransitiveIdeal` and `TransitiveIdealGraded`, namely:
     19B. Note that there were some issues with `TransitiveIdeal` and `TransitiveIdealGraded`, namely:
    1620
    17  - Enumeration of `TransitiveIdeal` is claimed to be depth first search in the top level file `backtrack.py`, but in fact, it is neither breadth first neither depth first.
     21 - Enumeration of `TransitiveIdeal` is claimed to be depth first search in the top level file `backtrack.py`, but in fact, it is neither breadth first neither depth first. It is what I call a naive search.
    1822 - Enumeration of `TransitiveIdealGraded` is indeed breadth first as claimed but it does not make use of the graded hypothesis at all because it remembers every generated elements.
    1923