Changes between Version 34 and Version 36 of Ticket #6637
 Timestamp:
 05/11/14 00:30:47 (6 years ago)
Legend:
 Unmodified
 Added
 Removed
 Modified

Ticket #6637

Property
Status
changed from
needs_work
toneeds_review

Property
Commit
changed from
42262457c67606ba2861e9ba7b5cb6f20450f09d
to766a1b0d7a09c8d9597308592db9543145e61751

Property
Status
changed from

Ticket #6637 – Description
v34 v36 9 9 2. Deprecate `TransitiveIdeal`, `TransitiveIdealGraded` and `SearchForest` as entry point. 10 10 11 3. `TransitiveIdeal(succ, seeds)` keeps the same behavior as before and is now the same as `RecursivelyEnumeratedSet(seeds, succ, structure=None, enumeration='naive')`. 12 13 4. `TransitiveIdealGraded(succ, seeds, max_depth)` keeps the same behavior as before and is now the same as `RecursivelyEnumeratedSet(seeds, succ, structure=None, enumeration='breadth', max_depth=max_depth)`. 14 11 15 Remarks: 12 16 13 17 A. For now the code of `SearchForest` is still in `sage/combinat/backtrack.py`. It should be moved in `sage/sets/recursively_enumerated_set.pyx` in a later ticket. 14 18 15 B. Note that there are some issues with `TransitiveIdeal` and `TransitiveIdealGraded`, namely:19 B. Note that there were some issues with `TransitiveIdeal` and `TransitiveIdealGraded`, namely: 16 20 17  Enumeration of `TransitiveIdeal` is claimed to be depth first search in the top level file `backtrack.py`, but in fact, it is neither breadth first neither depth first. 21  Enumeration of `TransitiveIdeal` is claimed to be depth first search in the top level file `backtrack.py`, but in fact, it is neither breadth first neither depth first. It is what I call a naive search. 18 22  Enumeration of `TransitiveIdealGraded` is indeed breadth first as claimed but it does not make use of the graded hypothesis at all because it remembers every generated elements. 19 23