Opened 14 years ago

Closed 13 years ago

#6620 closed enhancement (fixed)

[with patch, positive review] add a method to the Gap class to access elements of records

Reported by: saliola Owned by: was
Priority: major Milestone: sage-4.1.2
Component: interfaces Keywords:
Cc: nborie, wdj Merged in: Sage 4.1.2.alpha0
Authors: Franco Saliola Reviewers: David Joyner, Minh Van Nguyen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Accessing elements of GAP records should be easier. 

            sage: rec = gap('rec( a := 1, b := "2" )')
            sage: gap.get_record_element(rec, 'a')
            1
            sage: gap.get_record_element(rec, 'b')
            2

Attachments (2)

trac_6620.patch​ (1.3 KB) - added by saliola 14 years ago.
trac_6620-reviewer.patch​ (892 bytes) - added by mvngu 13 years ago.
reviewer patch; fix typos in ReST format

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by saliola

Attachment: trac_6620.patch​ added

comment:1 Changed 14 years ago by saliola

Authors: → Franco Saliola
Cc: wdj added
Summary: add a method to the Gap class to access elements of records → [with patch; needs review] add a method to the Gap class to access elements of records

comment:2 Changed 14 years ago by wdj

Summary: [with patch; needs review] add a method to the Gap class to access elements of records → [with patch; positive review] add a method to the Gap class to access elements of records

Applies fine to 4.1.1.a0, and passes sage -testall. I also played with it a bit and could not find any bugs and the docstrings seem fine.

Changed 13 years ago by mvngu

Attachment: trac_6620-reviewer.patch​ added

reviewer patch; fix typos in ReST format

comment:3 Changed 13 years ago by mvngu

Summary: [with patch; positive review] add a method to the Gap class to access elements of records → [with patch, positive review] add a method to the Gap class to access elements of records

The patch trac_6620-reviewer.patch fixes some typos in ReST formatting introduced by trac_6620.patch. Such typos would result in warnings when (re)building the reference manual.

comment:4 Changed 13 years ago by mvngu

Merged in: → Sage 4.1.2.alpha0
Resolution: → fixed
Reviewers: → David Joyner, Minh Van Nguyen
Status: new → closed

Merged patches in this order:

  1. trac_6620.patch
  2. trac_6620-reviewer.patch
Note: See TracTickets for help on using tickets.