Opened 12 years ago

Closed 12 years ago

#6594 closed defect (fixed)

[with patch, positive review] doctest issue in "r.py" (follow-up to #6379)

Reported by: GeorgSWeber Owned by: GeorgSWeber
Priority: major Milestone: sage-4.1.1
Component: interfaces Keywords:
Cc: mvngu Merged in: Sage 4.1.1.alpha1
Authors: Georg S. Weber Reviewers: Minh Van Nguyen
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

If the file "r_commandlist.sobj" under $DOT_SAGE is missing, the first time you run a doctest over "r.py", you'll get:

sage -t  "devel/sage/sage/interfaces/r.py"                  
**********************************************************************
File "/Users/Shared/sage/sage-4.1.1.alpha0/devel/sage/sage/interfaces/r.py", line 838:
    sage: r.completions('tes')
Expected:
    ['testPlatformEquivalence', 'testVirtual']
Got:
    <BLANKLINE>
    Building R command completion list (this takes
    a few seconds only the first time you do it).
    To force rebuild later, delete /Users/georgweber/.sage//r_commandlist.sobj.
    ['testPlatformEquivalence', 'testVirtual']
**********************************************************************
1 items had failures:
   1 of   3 in __main__.example_34
***Test Failed*** 1 failures.
For whitespace errors, see the file /Users/Shared/sage/sage-4.1.1.alpha0/tmp/.doctest_r.py

or some error message closely related. If you run the doctest a second time, the failure vanishes, since the file in $DOT_SAGE had been built. But that is not something one wants to happen during doctesting.

Attachments (1)

trac_6594-R_doctest.patch (678 bytes) - added by GeorgSWeber 12 years ago.
tested against 4.1.1.alpha0

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by GeorgSWeber

tested against 4.1.1.alpha0

comment:1 Changed 12 years ago by GeorgSWeber

  • Authors set to Georg S. Weber
  • Cc mvngu added
  • Summary changed from doctest issue in "r.py" (follow-up to #6379) to [with patch, needs review] doctest issue in "r.py" (follow-up to #6379)

Minh, could please review this one-liner? (Cough, cough ...)

comment:2 Changed 12 years ago by GeorgSWeber

Doctesting r.py after (if it there at all) deleting the file $HOME/.sage/r_commandlist.sobj will always fail --- unless one has this patch applied. So I hope it is a very easy review.

comment:3 Changed 12 years ago by mvngu

  • Reviewers set to Minh Van Nguyen
  • Summary changed from [with patch, needs review] doctest issue in "r.py" (follow-up to #6379) to [with patch, positive review] doctest issue in "r.py" (follow-up to #6379)

With

~/.sage/r_commandlist.sobj

doctests passed. Without it, doctests failed. With patch and with ~/.sage/r_commandlist.sobj: doctests passed. Doctests also passed with the patch and without ~/.sage/r_commandlist.sobj. So this is a

***************
POSITIVE REVIEW
***************

Let's make R statistically significant :-)

comment:4 Changed 12 years ago by mvngu

  • Merged in set to Sage 4.1.1.alpha1
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.