Opened 11 years ago

Last modified 8 years ago

#6588 closed enhancement

Categories for root systems — at Version 8

Reported by: nthiery Owned by: mhansen
Priority: major Milestone: sage-5.0
Component: combinatorics Keywords: root systems, categories
Cc: sage-combinat, mshimo@… Merged in:
Authors: Nicolas M. Thiéry Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #10817 Stopgaps:

Description (last modified by nthiery)

See the top of the patch for a complete description of the changes.

Status: the patch is basically good to go. I still want to add coercions from the root lattice to the weight lattice and friends; other than that, the math review can start (done now!)

Note: the indentation is currently wrong in a couple places (2 spaces instead of 4) in order to make the diff small. I'll fix that indentation for the very final patch.

Change History (8)

comment:1 Changed 8 years ago by nthiery

  • Authors set to Nicolas M. Thiéry
  • Cc mshimo@… added
  • Dependencies set to #10963, #10817
  • Description modified (diff)
  • Report Upstream set to N/A

comment:2 Changed 8 years ago by nthiery

  • Description modified (diff)
  • Summary changed from Root systems: categorification to Categories for root systems

comment:3 Changed 8 years ago by nthiery

  • Description modified (diff)

comment:4 follow-up: Changed 8 years ago by nthiery

  • Status changed from new to needs_review

The updated patch adds many missing doctests, and improves coxeter diagrams. It's probably close to completion, up to fixing some potentially failing doctests.

comment:5 Changed 8 years ago by nthiery

Beside, I commuted it up the Sage-Combinat queue. In principle, there should not be other dependencies than the listed ones.

comment:6 in reply to: ↑ 4 Changed 8 years ago by nthiery

Replying to nthiery:

The updated patch adds many missing doctests, and improves coxeter diagrams. It's probably close to completion, up to fixing some potentially failing doctests.

There are indeed a couple minor ones:

http://sage.math.washington.edu/home/nthiery/trac_6588-categories-root_systems-nt.patch-testlog

Note: that's with the following patches applied on 5.0.beta5:

trac_12476-lattice_join_matrix_speedup-fh.patch
trac_9469-category-membership_without_arguments-nt.patch
trac_10603-union_enumset_elconstr_fix-fh.patch
trac_12528_free_module-optimize-nt.patch
trac_10817-generalized_associahedra-cs.patch
trac_10817-generalized_associahedra-review-nt.patch
trac_12078-see_also-fh.patch
trac_9128-intersphinx_python_database-fh.patch
trac_9128-sphinx_links_all-fh.patch
trac_12527-fraction_field-is_exact_optimization-nt.patch
trac_12510-nonzero_equal_consistency-fh.patch
trac_12536-linear_extensions-as.patch
trac_12518-enumerated_set_from_iterator-vd.patch
trac_11880.patch
trac_11880-graph_classes-review-nt.patch
trac_7980-multiple-realizations-nt.patch
trac_7980-multiple-realizations-review-nt.patch
trac_6588-categories-root_systems-nt.patch

Off for skiing :-)

comment:7 Changed 8 years ago by nthiery

I fixed the doctests failures due to this patch. Most of them where due to the fact that affine weyl groups are iterable now, which gives a nicer an_element on any free module thereupon.

The other doctests failures showing up in the log are related to #12518 (or to the ISGCI patch, but that's because I did not upload the appropriate database on my test server).

The review can start!

comment:8 Changed 8 years ago by nthiery

  • Dependencies changed from #10963, #10817 to #10817
  • Description modified (diff)

Patch updated after a bug report by Mark; see end of patch description

Note: See TracTickets for help on using tickets.