Opened 14 years ago
Closed 13 years ago
#6584 closed enhancement (fixed)
Use pari to do ideal intersections
| Reported by: | fwclarke | Owned by: | davidloeffler |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | number fields | Keywords: | ideal, intersecton, pari |
| Cc: | davidloeffler, ncalexan | Merged in: | sage-4.3.1.rc1 |
| Authors: | Francis Clarke | Reviewers: | John Cremona |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
GitHub link to the corresponding issue
Description
As an addendum to #6457, I propose reworking the code to use the pari function idealintersect. The patch does this. The result is a significantly faster function.
Attachments (1)
Change History (4)
Changed 14 years ago by
| Attachment: | trac_6584.patch added |
|---|
comment:1 Changed 13 years ago by
| Report Upstream: | → N/A |
|---|---|
| Status: | new → needs_review |
The patch still applies to 4.3.1.rc0 (miracle!) and all tests in rings/number_field and libs/pari pass.
comment:2 Changed 13 years ago by
| Status: | needs_review → positive_review |
|---|
comment:3 Changed 13 years ago by
| Merged in: | → sage-4.3.1.rc1 |
|---|---|
| Resolution: | → fixed |
| Reviewers: | → John Cremona |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
patch against 4.1.1.alpha0