Opened 14 years ago

Closed 11 years ago

Last modified 4 weeks ago

#6582 closed defect (duplicate)

Potential issue in polybori - 0.5rc.p8 and/or 0.5rc.p9

Reported by: drkirkby Owned by: tbd
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: porting: Solaris Keywords:
Cc: AlexanderDreyer, PolyBoRi, drkirkby Merged in:
Authors: Reviewers: Alexander Dreyer
Report Upstream: Completely fixed; Fix reported upstream Work issues:
Branch: Commit:
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description (last modified by AlexanderDreyer)

I believe there is an issue which *may* affect Solaris with polybori 0.5rc.p8, and assuming my patch to .p9 gets positive review, will affect that too, as I have not tried to fix this.

Here are some notes I put in patches/custom.py 

# Note, these 'SAGE_DEBUG' linker flags added by someone
# are likely to break if used on Solaris
# with the Sun linker, as -p option to the Sun linker is:
#         [-p auditlib]   identify audit library to accompany this object
# This has not been confirmed, and I don't have time to test it.
# David Kirkby, 21st July 2009. I suggest this is revisited by someone soon.
if os.environ.has_key('SAGE_DEBUG'):
    CPPDEFINES=[]
    CCFLAGS=[" -pg"] + CCFLAGS
    CXXFLAGS=[" -pg"] + CXXFLAGS
    LINKFLAGS=[" -pg"]

Duplicate of #11575.

Change History (10)

comment:1 Changed 13 years ago by drkirkby

Milestone: sage-4.1.2 → sage-4.1.3

Another issue, which is this case I am 100% sure about, is that PolyBoRi? (as of polybori-0.6.3-20090827.spkg) in sage-4.1.2.alpha4 is that PolyBoRi? is sending GNU-specific options to the Sun compiler. See #7034

comment:2 Changed 13 years ago by drkirkby

Cc: polybori-discuss@… david.kirkby@… added
Report Upstream: → N/A

comment:3 Changed 11 years ago by jdemeyer

Is this still a problem?

comment:4 Changed 11 years ago by AlexanderDreyer

Cc: AlexanderDreyer PolyBoRi added; polybori-discuss@… removed
Report Upstream: N/A → Completely fixed; Fix reported upstream

No, it was fixed. For instance, in #12655 for PolyBoRi 0.8.1.

comment:5 Changed 11 years ago by AlexanderDreyer

Description: modified (diff)
Status: new → needs_review

Duplicate of#12655.

comment:6 Changed 11 years ago by AlexanderDreyer

Status: needs_review → positive_review

Abusing "positive review".

comment:7 Changed 11 years ago by jdemeyer

Milestone: sage-5.1 → sage-duplicate/invalid/wontfix
Reviewers: → Alexander Dreyer

In such cases, you should set the milestone to "sage-duplicate/invalid/wontfix".

comment:8 in reply to:  7 Changed 11 years ago by AlexanderDreyer

Replying to jdemeyer:

In such cases, you should set the milestone to "sage-duplicate/invalid/wontfix".

Thanks, I'll do so next time.

comment:9 Changed 11 years ago by jdemeyer

Resolution: → duplicate
Status: positive_review → closed

comment:10 Changed 4 weeks ago by chapoton

Cc: drkirkby added; david.kirkby@… removed
Note: See TracTickets for help on using tickets.