#6573 closed defect (fixed)
[with patch, positive review] fix docstring from #5651
| Reported by: | mvngu | Owned by: | tba |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.1.1 |
| Component: | documentation | Keywords: | |
| Cc: | wcauchois, davidloeffler | Merged in: | Sage 4.1.1.alpha1 |
| Authors: | Minh Van Nguyen | Reviewers: | David Loeffler |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
That rebased patch at #5651 contains doctrings that doesn't conform with conventions for formatting docstrings. In particular, in sage/plot/bar_chart.py:
131 Extra options will get passed on to show(), as long as they are valid:
In sage/plot/bezier_path.py:
171 Extra options will get passed on to show(), as long as they are valid:
In sage/plot/matrix_plot.py:
58 Extra options will get passed on to show(), as long as they are valid: 62 Extra options will get passed on to show(), as long as they are valid:
In sage/plot/polygon.py:
255 Extra options will get passed on to show(), as long as they are valid:
Attachments (2)
Change History (6)
Changed 14 years ago by
| Attachment: | trac_6573-docstring-fix.patch added |
|---|
comment:1 Changed 14 years ago by
| Authors: | → Minh Van Nguyen |
|---|---|
| Cc: | davidloeffler added |
| Summary: | fix docstring from #5651 → [with patch, needs review] fix docstring from #5651 |
David: Can I ask you to review this?
Changed 14 years ago by
| Attachment: | trac_6573-review.patch added |
|---|
comment:2 Changed 14 years ago by
| Reviewers: | → David Loeffler |
|---|---|
| Summary: | [with patch, needs review] fix docstring from #5651 → [with patch, positive review] fix docstring from #5651 |
Looks fine to me; but it looks like the Bezier paths module isn't in the reference manual. I've uploaded a tiny patch that fixes this.
comment:3 Changed 14 years ago by
| Merged in: | → Sage 4.1.1.alpha1 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Merged both patches.
comment:4 Changed 7 years ago by
| Description: | modified (diff) |
|---|---|
| Report Upstream: | → N/A |
Note: See
TracTickets for help on using
tickets.
based on Sage 4.1.1.alpha0