Opened 10 years ago

Closed 10 years ago

#6549 closed enhancement (fixed)

[with patch, positive review] reinstate some doctests in schemes/plane_curves/affine_curve.py

Reported by: AlexGhitza Owned by: AlexGhitza
Priority: minor Milestone: sage-4.1.2
Component: doctest coverage Keywords:
Cc: Merged in: Sage 4.1.2.alpha0
Authors: Alex Ghitza Reviewers: Craig Citro
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Some doctests in schemes/plane_curves/affine_curve.py are marked "not tested" with the comment that they crash on OS X intel. This appears to not be the case any more:

aghitza@192-168-1-2:~/opt/sage-4.1$ ./sage
----------------------------------------------------------------------
| Sage Version 4.1, Release Date: 2009-07-09                         |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
sage: x, y = (GF(17)['x,y']).gens()
sage: C = Curve(x^2+y^5+x*y-19)
sage: v = C.rational_points(algorithm='bn')
sage: w = C.rational_points(algorithm='enum')
sage: len(v)
20
sage: v == w
True
sage: 
Exiting SAGE (CPU time 0m0.23s, Wall time 1m59.83s).
Exiting spawned Singular process.
aghitza@192-168-1-2:~/opt/sage-4.1$ uname -a
Darwin 192-168-1-2.tpgi.com.au 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386

Attachments (1)

trac_6549.patch (2.0 KB) - added by AlexGhitza 10 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by AlexGhitza

  • Authors set to Alex Ghitza
  • Owner changed from tbd to AlexGhitza
  • Status changed from new to assigned
  • Summary changed from reinstate some doctests in schemes/plane_curves/affine_curve.py to [with patch, needs review] reinstate some doctests in schemes/plane_curves/affine_curve.py

comment:2 Changed 10 years ago by craigcitro

  • Reviewers set to Craig Citro
  • Summary changed from [with patch, needs review] reinstate some doctests in schemes/plane_curves/affine_curve.py to [with patch, with positive review modulo one tiny detail] reinstate some doctests in schemes/plane_curves/affine_curve.py

Looks good. Works fine on my MacBook? Pro, and also seems to work fine on sage.math. My one potential complaint: I think there's a missing level of nesting in the docstring. That is, I think the three bullets after "algorithm" should be in a sub-list. (I recognize that this patch doesn't touch the docstring other than the doctests, but I still think they should be fixed since we're here.)

Changed 10 years ago by AlexGhitza

comment:3 Changed 10 years ago by AlexGhitza

Docstring fixed, new patch replaces the old.

comment:4 Changed 10 years ago by craigcitro

  • Summary changed from [with patch, with positive review modulo one tiny detail] reinstate some doctests in schemes/plane_curves/affine_curve.py to [with patch, with positive review] reinstate some doctests in schemes/plane_curves/affine_curve.py

Nice.

comment:5 Changed 10 years ago by mvngu

  • Merged in set to Sage 4.1.2.alpha0
  • Resolution set to fixed
  • Status changed from assigned to closed
  • Summary changed from [with patch, with positive review] reinstate some doctests in schemes/plane_curves/affine_curve.py to [with patch, positive review] reinstate some doctests in schemes/plane_curves/affine_curve.py
Note: See TracTickets for help on using tickets.