Opened 13 years ago
Closed 13 years ago
#6540 closed defect (fixed)
[with patch, positive review] g.add_edge((u,v), label=l) syntax unsupported for C graphs
Reported by: | Robert Miller | Owned by: | Robert Miller |
---|---|---|---|
Priority: | major | Milestone: | sage-4.1.1 |
Component: | graph theory | Keywords: | |
Cc: | Jason Grout | Merged in: | sage-4.1.1.alpha0 |
Authors: | Robert Miller | Reviewers: | Jason Grout |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Attachments (1)
Change History (7)
Changed 13 years ago by
Attachment: | trac_6540-edge_syntax.patch added |
---|
comment:1 Changed 13 years ago by
Cc: | Jason Grout added |
---|
comment:2 Changed 13 years ago by
comment:3 Changed 13 years ago by
Summary: | [with patch, needs review] g.add_edge((u,v), label=l) syntax unsupported for C graphs → [with patch, positive review] g.add_edge((u,v), label=l) syntax unsupported for C graphs |
---|
comment:4 Changed 13 years ago by
Reviewers: | → Jason Grout |
---|
comment:5 Changed 13 years ago by
Authors: | → Robert Miller |
---|
comment:6 Changed 13 years ago by
Merged in: | → sage-4.1.1.alpha0 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
This looks good and passes tests in graph.py.
The function has a blanket except: statement, which should instead trap the specific error it is expecting. But that is not this issue.
As a side note, I think there are too many syntax choices for creating edges, which not only creates obscure corner cases and parsing code like this, but also leads to code that goes against the python philosophy that there should be one way to do things ("http://trac.sagemath.org/sage_trac/raw-attachment/ticket/6540/trac_6540-edge_syntax.patch"). I don't have time to do anything about it, so this is just a hollow complaint now :).