Opened 13 years ago

Closed 13 years ago

#6540 closed defect (fixed)

[with patch, positive review] g.add_edge((u,v), label=l) syntax unsupported for C graphs

Reported by: Robert Miller Owned by: Robert Miller
Priority: major Milestone: sage-4.1.1
Component: graph theory Keywords:
Cc: Jason Grout Merged in: sage-4.1.1.alpha0
Authors: Robert Miller Reviewers: Jason Grout
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description


Attachments (1)

trac_6540-edge_syntax.patch (1.4 KB) - added by Robert Miller 13 years ago.

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by Robert Miller

Attachment: trac_6540-edge_syntax.patch added

comment:1 Changed 13 years ago by Jason Grout

Cc: Jason Grout added

comment:2 Changed 13 years ago by Jason Grout

This looks good and passes tests in graph.py.

The function has a blanket except: statement, which should instead trap the specific error it is expecting. But that is not this issue.

As a side note, I think there are too many syntax choices for creating edges, which not only creates obscure corner cases and parsing code like this, but also leads to code that goes against the python philosophy that there should be one way to do things ("http://trac.sagemath.org/sage_trac/raw-attachment/ticket/6540/trac_6540-edge_syntax.patch"). I don't have time to do anything about it, so this is just a hollow complaint now :).

comment:3 Changed 13 years ago by Jason Grout

Summary: [with patch, needs review] g.add_edge((u,v), label=l) syntax unsupported for C graphs[with patch, positive review] g.add_edge((u,v), label=l) syntax unsupported for C graphs

comment:4 Changed 13 years ago by Jason Grout

Reviewers: Jason Grout

comment:5 Changed 13 years ago by Jason Grout

Authors: Robert Miller

comment:6 Changed 13 years ago by Minh Van Nguyen

Merged in: sage-4.1.1.alpha0
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.