Opened 12 years ago

Closed 12 years ago

#6526 closed defect (fixed)

[with patch, positive review] remove naive suffix trees

Reported by: rlm Owned by: mhansen
Priority: major Milestone: sage-4.1.1
Component: combinatorics Keywords:
Cc: saliola Merged in: sage-4.1.1.alpha0
Authors: Robert Miller Reviewers: Franco Saliola
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This is one of the obstructions to switching the graph backends over to Cython by default.

To quote Franco: 

But all the doctest failures occur in the NaiveSuffixTreeClass, which
is a naive implementation. This code was only intended for testing
purposes, so I think it is fine to delete it (delete both
NaiveSuffixTree and NaiveSuffixTreeClass). I am pretty certain it is
not used anywhere else (it should not be, if it is), because it is a
very slow implementation (hence, the name naive).

Attachments (1)

trac_6526-remove-naive-suffix-tree.patch​ (10.0 KB) - added by rlm 12 years ago.
based on #6519

Download all attachments as: .zip

Change History (5)

comment:1 Changed 12 years ago by rlm

This will be based on #6519.

Changed 12 years ago by rlm

based on #6519

comment:2 Changed 12 years ago by rlm

  • Authors set to Robert Miller
  • Cc saliola added
  • Summary changed from remove naive suffix trees to [with patch, needs review] remove naive suffix trees

comment:3 Changed 12 years ago by saliola

  • Summary changed from [with patch, needs review] remove naive suffix trees to [with patch, positive review] remove naive suffix trees

Positive review.

comment:4 Changed 12 years ago by mvngu

  • Merged in set to sage-4.1.1.alpha0
  • Resolution set to fixed
  • Reviewers set to Franco Saliola
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.