Opened 12 years ago

Closed 7 years ago

#6520 closed enhancement (fixed)

[with patch, needs work] Implement cached_function with weakref cache

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: misc Keywords: cached function, weakref
Cc: sage-combinat, roed, SimonKing Merged in:
Authors: Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by nthiery)

The preliminary attached patch (taken from the Sage-Combinat patch server) implements a variant of cached_function where the cache uses weak references. Again: preliminary: the test do not pass, ...

Feedback welcome!

The first planned application is for homsets, after the category stuff #5985 will be in.

Attachments (1)

trac_6520_weakref-cached-function-dr.patch​ (7.1 KB) - added by nthiery 12 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by nthiery

  • Description modified (diff)
  • Owner changed from cwitty to nthiery
  • Status changed from new to assigned
  • Type changed from defect to enhancement

comment:2 Changed 12 years ago by nthiery

  • Cc roed added
  • Description modified (diff)

Changed 12 years ago by nthiery

comment:3 follow-up: Changed 7 years ago by mmezzarobba

  • Cc SimonKing added
  • Milestone changed from sage-feature to sage-duplicate/invalid/wontfix
  • Report Upstream set to N/A
  • Status changed from needs_work to needs_review

Done in #12215?

comment:4 in reply to: ↑ 3 Changed 7 years ago by SimonKing

Replying to mmezzarobba:

Done in #12215?

I think so.

comment:5 Changed 7 years ago by tscrim

  • Authors David Roe deleted
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

This is the same feature as @weak_cached_method from #12215.

comment:6 Changed 7 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.