Opened 10 years ago

Closed 10 years ago

#6457 closed defect (fixed)

[with patch, positive review] Intersection of ideals in a number field

Reported by: davidloeffler Owned by: was
Priority: minor Milestone: sage-4.1.1
Component: number theory Keywords: ideals
Cc: Merged in: sage-4.1.1.alpha0
Authors: David Loeffler Reviewers: Nick Alexander
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This is not difficult but for some reason it wasn't implemented before. Here it is.

Attachments (1)

trac_6457-ideal_intersection.patch (1.8 KB) - added by davidloeffler 10 years ago.
patch against 4.1.alpha2

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by davidloeffler

patch against 4.1.alpha2

comment:1 Changed 10 years ago by davidloeffler

  • Keywords ideals added; ideal removed
  • Summary changed from Intersection of ideals in a number field to [with patch, needs review] Intersection of ideals in a number field

comment:2 Changed 10 years ago by ncalexan

  • Authors set to Nick Alexander
  • Reviewers set to David Loeffler
  • Summary changed from [with patch, needs review] Intersection of ideals in a number field to [with patch, positive review] Intersection of ideals in a number field

These doctests don't convince me that the the results are correct, but I don't see a one line way to assert that, so: positive review!

comment:3 Changed 10 years ago by mvngu

  • Authors changed from Nick Alexander to David Loeffler
  • Merged in set to sage-4.1.1.alpha0
  • Resolution set to fixed
  • Reviewers changed from David Loeffler to Nick Alexander
  • Status changed from new to closed

I assume David is the author of trac_6457-ideal_intersection.patch, since Nick reviewed this ticket. David, the patch trac_6457-ideal_intersection.patch doesn't contain your username. So I'm committing it in your name.

Note: See TracTickets for help on using tickets.