[with patch, positive review] improve sbox linear and differences matrices computation
Reported by: 
ylchapuy 
Owned by: 
somebody 
Priority:

minor

Milestone:

sage4.1.1

Component:

cryptography

Keywords:


Cc:

malb

Merged in:

sage4.1.1.alpha0

Authors:

Yann LaigleChapuy

Reviewers:

Martin Albrecht

Report Upstream:

N/A

Work issues:


Branch:


Commit:


Dependencies:


Stopgaps:


In particular, use walsh transform for linear_approximation_matrix.
Change History (9)
Cc: 
malb added

Summary: 
improve sbox linear and differences matrices computation →
[with patch, needs review] improve sbox linear and differences matrices computation

Summary: 
[with patch, needs review] improve sbox linear and differences matrices computation →
[with patch, needs work] improve sbox linear and differences matrices computation

Reviewers: 
→ Martin Albrecht

Summary: 
[with patch, needs work] improve sbox linear and differences matrices computation →
[with patch, positive review] improve sbox linear and differences matrices computation

Merged in: 
→ sage4.1.1.alpha0

Resolution: 
→ fixed

Status: 
new →
closed

Hi there, it is embarrassing how bad my naive original code was. Here's a comparison (for the release tour)
Old*
*New*
The code looks good, doctests pass.
The only issue: the
sage coverage
script will pick up_walsh_transform
and complain that it isn't documented and doctested.Of course it is impossible to doctest this inner function directly, but the keyword
# indirect doctest
will do the trick.This is a positive review except for the missing documentation.