Opened 13 years ago
Closed 13 years ago
#6454 closed enhancement (fixed)
[with patch, positive review] improve sbox linear and differences matrices computation
Reported by: | ylchapuy | Owned by: | somebody |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.1.1 |
Component: | cryptography | Keywords: | |
Cc: | Martin Albrecht | Merged in: | sage-4.1.1.alpha0 |
Authors: | Yann Laigle-Chapuy | Reviewers: | Martin Albrecht |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
In particular, use walsh transform for linear_approximation_matrix.
Attachments (2)
Change History (9)
Changed 13 years ago by
Attachment: | trac_6454_sbox.patch added |
---|
comment:1 Changed 13 years ago by
Cc: | Martin Albrecht added |
---|---|
Summary: | improve sbox linear and differences matrices computation → [with patch, needs review] improve sbox linear and differences matrices computation |
comment:2 Changed 13 years ago by
Summary: | [with patch, needs review] improve sbox linear and differences matrices computation → [with patch, needs work] improve sbox linear and differences matrices computation |
---|
Changed 13 years ago by
Attachment: | trac_6454_review.patch added |
---|
comment:3 Changed 13 years ago by
Reviewers: | → Martin Albrecht |
---|
Both patches should be applied.
I added an indirect doctest. I give myself a positive review, feel free to correct me if you disagree.
comment:4 Changed 13 years ago by
Summary: | [with patch, needs work] improve sbox linear and differences matrices computation → [with patch, positive review] improve sbox linear and differences matrices computation |
---|
comment:6 Changed 13 years ago by
Just to let people know, this has been merged in sage-4.1.1-alpha0. I can't close this ticket because I don't have the privilege to do so. Sorry, folks :-(
comment:7 Changed 13 years ago by
Merged in: | → sage-4.1.1.alpha0 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Hi there, it is embarrassing how bad my naive original code was. Here's a comparison (for the release tour)
Old*
*New*
The code looks good, doctests pass.
The only issue: the
sage -coverage
script will pick up_walsh_transform
and complain that it isn't documented and doctested.Of course it is impossible to doctest this inner function directly, but the keyword
# indirect doctest
will do the trick.This is a positive review except for the missing documentation.