Opened 14 years ago
Closed 14 years ago
#6450 closed enhancement (fixed)
[with patch, positive review] add generic group functions to the documentation
Reported by: | ylchapuy | Owned by: | tba |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.1.1 |
Component: | documentation | Keywords: | generic group documentation |
Cc: | Merged in: | sage-4.1.1.alpha0 | |
Authors: | Yann Laigle-Chapuy | Reviewers: | John Cremona |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Those are the functions in sage/groups/generic.py
Attachments (2)
Change History (5)
Changed 14 years ago by
Attachment: | trac_6450_generic_group_doc.patch added |
---|
Changed 14 years ago by
Attachment: | trac_6450_review.patch added |
---|
comment:1 Changed 14 years ago by
Keywords: | generic group documentation added |
---|---|
Reviewers: | → John Cremona |
Summary: | add generic group functions to the documentation → [with new patch, needs review] add generic group functions to the documentation |
Thanks for working on this! It's a great thing to have this file appearing in the reference manual.
I checked that the docs built ok after the patch (which applied fine to 4.1.alpha2), then added a second patch which tidies up the documentation a bit -- since I wrote most of it, I thought that was my duty.
ylchapuy, if you approve of my additional patch then you can give this a postive review.
comment:2 Changed 14 years ago by
Summary: | [with new patch, needs review] add generic group functions to the documentation → [with patch, positive review] add generic group functions to the documentation |
---|
Nice job. It looks fine to me.
comment:3 Changed 14 years ago by
Merged in: | → sage-4.1.1.alpha0 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Merged both patches.
Note: See
TracTickets for help on using
tickets.
Apply after previous