Opened 13 years ago

Closed 13 years ago

#6438 closed enhancement (fixed)

[with spkg, positive review] Upgrade to Cython 0.11.2

Reported by: Robert Bradshaw Owned by: Michael Abshoff
Priority: major Milestone: sage-4.1.1
Component: packages: standard Keywords:
Cc: Merged in: Sage 4.1.1.alpha1
Authors: Robert Bradshaw Reviewers: Minh Van Nguyen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

At the very least, native complex support will be valuable.

The spkg at http://sage.math.washington.edu/home/robertwb/cython/ built and passed all doctests a couple of versions back.

Attachments (1)

6438-cython.patch (788 bytes) - added by Robert Bradshaw 13 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 13 years ago by Mike Hansen

Summary: Upgrade to Cython 0.11.2[with spkg, needs review] Upgrade to Cython 0.11.2

comment:2 Changed 13 years ago by Robert Bradshaw

We should update to the latest tip to fix the numpy issue.

comment:3 Changed 13 years ago by Jason Grout

Does your comment mean that we need a new spkg? Is this a "needs work" ticket now?

comment:4 Changed 13 years ago by Jason Grout

Summary: [with spkg, needs review] Upgrade to Cython 0.11.2[with spkg, needs work] Upgrade to Cython 0.11.2

comment:5 Changed 13 years ago by Jason Grout

On the other hand, the spkg seems fine, except that the SPKG.txt file does not include a changelog of any sort. Shouldn't this be added?

comment:6 Changed 13 years ago by Robert Bradshaw

Summary: [with spkg, needs work] Upgrade to Cython 0.11.2[with spkg, needs review] Upgrade to Cython 0.11.2

http://sage.math.washington.edu/home/robertwb/cython/cython-0.11.2.1.spkg

I don't see anything in SPKG.txt that needs changing--the changelog would be pretty boring if it was there ("Upgraded to version x.y.z" * 100).

Changed 13 years ago by Robert Bradshaw

Attachment: 6438-cython.patch added

comment:7 Changed 13 years ago by Robert Bradshaw

All tests pass with the above spkg and patch.

comment:8 Changed 13 years ago by Minh Van Nguyen

The SPKG at

http://sage.math.washington.edu/home/robertwb/cython/cython-0.11.2.1.spkg

doesn't contain a file called .hgignore like the current version in Sage 4.1. So when one executes the command

hg status

one sees a lot of source files. I've added a .hgignore file to the repository of that SPKG. The updated SPKG is up at

http://sage.math.washington.edu/home/mvngu/patch/cython-0.11.2.1.spkg

All doctests passed with the latter SPKG and 6438-cython.patch.

comment:9 Changed 13 years ago by Minh Van Nguyen

Authors: Robert Bradshaw
Merged in: Sage 4.1.1.alpha1
Resolution: fixed
Reviewers: Minh Van Nguyen
Status: newclosed
Summary: [with spkg, needs review] Upgrade to Cython 0.11.2[with spkg, positive review] Upgrade to Cython 0.11.2
Note: See TracTickets for help on using tickets.