Opened 13 years ago

Closed 13 years ago

#6372 closed enhancement (fixed)

[with patch, positive review] Move a few 3d plot files into plot3d

Reported by: Karl-Dieter Crisman Owned by: William Stein
Priority: minor Milestone: sage-4.1
Component: graphics Keywords:
Cc: Merged in: sage-4.1.alpha2
Authors: Karl-Dieter Crisman Reviewers: Minh Van Nguyen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

tachyon.py and tri_plot.py really belong in plot/plot3d, and there is an extra texture.py which is unused to remove.

Attachments (2)

trac_6372.patch (109.0 KB) - added by Karl-Dieter Crisman 13 years ago.
Depends on #6269
trac_6372-rebased.patch (108.1 KB) - added by Minh Van Nguyen 13 years ago.
rebased against Sage 4.1.alpha1

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by Karl-Dieter Crisman

Attachment: trac_6372.patch added

Depends on #6269

comment:1 Changed 13 years ago by Karl-Dieter Crisman

Summary: Move a few 3d plot files into plot3d[with patch, needs review] Move a few 3d plot files into plot3d

This patch also makes necessary changes in a few other files to allow this, including in the plot3d rest documentation.

comment:2 Changed 13 years ago by Minh Van Nguyen

Summary: [with patch, needs review] Move a few 3d plot files into plot3d[with patch, needs rebase] Move a few 3d plot files into plot3d

This also needs a rebase, since #6269 requires a rebase.

comment:3 Changed 13 years ago by Minh Van Nguyen

kcrisman: Can you rebase the patch?

Changed 13 years ago by Minh Van Nguyen

Attachment: trac_6372-rebased.patch added

rebased against Sage 4.1.alpha1

comment:4 Changed 13 years ago by Minh Van Nguyen

Authors: Karl-Dieter Crisman
Reviewers: Minh Van Nguyen
Summary: [with patch, needs rebase] Move a few 3d plot files into plot3d[with patch, positive review] Move a few 3d plot files into plot3d

The patch trac_6372-rebased.patch is rebased against Sage 4.1.alpha1. It depends on #6269 and likely to also depends on #5640. So patches should be applied in the following order:

  1. the rebased patch at #6269
  2. the rebased patch at #5640
  3. the rebased patch on this ticket

comment:5 Changed 13 years ago by Kelly Boothby

Merged in: sage-4.1.alpha2
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.