Opened 13 years ago
Closed 13 years ago
#637 closed enhancement (fixed)
[with patch; positive review] notebook improvement -- upload allow txt worksheets.
Reported by: | was | Owned by: | boothby |
---|---|---|---|
Priority: | minor | Milestone: | sage-3.0.2 |
Component: | notebook | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
> 1) It would be nice if one could upload directly the text of a > worksheet to SAGE and have it automatically evaluated as an > uploaded worksheet. I like this suggestion. It has always been on my (perhaps only mental) todo list. To clarify -- this means making it in the "upload a file" box you can upload plain text files in addition to .sws files.
Attachments (3)
Change History (17)
comment:1 Changed 13 years ago by
- Milestone changed from sage-2.9 to sage-2.9.1
- Priority changed from major to minor
comment:2 Changed 13 years ago by
- Description modified (diff)
- Summary changed from notebook improvement -- to notebook improvement -- upload allow txt worksheets.
comment:3 Changed 13 years ago by
comment:4 Changed 13 years ago by
19:55 < tclemans> for the upload a plain text worksheet ticket: would it just work to create an empty worksheet and then call edit_save with the plain text? 19:55 < wstein-3121> tclemans -- yep. 19:55 < wstein-3121> That's exactly right.
Changed 13 years ago by
comment:5 Changed 13 years ago by
- Summary changed from notebook improvement -- upload allow txt worksheets. to [with patch; needs review] notebook improvement -- upload allow txt worksheets.
The attached patch:
- Implements uploading .txt files (plain text worksheets).
- Adds lots of related documentation, docstrings, doctests, etc., and clean up some related code.
comment:6 Changed 13 years ago by
- Summary changed from [with patch; needs review] notebook improvement -- upload allow txt worksheets. to [with patch; negative review] notebook improvement -- upload allow txt worksheets.
I can't seem to apply the patch.
sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/637/sage-637.patch?format=raw') Attempting to load remote file: http://trac.sagemath.org/sage_trac/attachment/ticket/637/sage-637.patch?format=raw Loading: [..] cd "/home/tclemans/sage-3.0/devel/sage" && hg status cd "/home/tclemans/sage-3.0/devel/sage" && hg status cd "/home/tclemans/sage-3.0/devel/sage" && hg import "/home/tclemans/.sage/temp/sage/27583/tmp_0.patch" applying /home/tclemans/.sage/temp/sage/27583/tmp_0.patch patching file sage/server/notebook/notebook.py Hunk #1 FAILED at 148 1 out of 4 hunks FAILED -- saving rejects to file sage/server/notebook/notebook.py.rej abort: patch failed to apply sage: version() 'SAGE Version 3.0.1, Release Date: 2008-05-05'
comment:7 Changed 13 years ago by
- Summary changed from [with patch; negative review] notebook improvement -- upload allow txt worksheets. to [with patch; needs review] notebook improvement -- upload allow txt worksheets.
This is likely a dependency issue. William can provide a dependency tree for the 15+ notebook patches he did during Bug Day 12.
Cheers,
Michael
comment:8 Changed 13 years ago by
I applied the patches in the following order and had no problems:
1733 1864 2359 2636 2884 2992 3024 3053 637
comment:9 Changed 13 years ago by
- Description modified (diff)
- Summary changed from [with patch; needs review] notebook improvement -- upload allow txt worksheets. to [with patch; mostly positive review] notebook improvement -- upload allow txt worksheets.
Works, except when I tried to upload a rather old (from SD3) worksheet:
2008-05-11 22:47:55-0700 [-] cd "/home/boothby/.sage/temp/eight/32244/dir_1"; tar -jxf "/home/boothby/.sage/temp/eight/32244/dir_0/pippenger.sws" 2008-05-11 22:47:55-0700 [-] Exception rendering: 2008-05-11 22:47:55-0700 [-] Unhandled Error Traceback (most recent call last): File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/twisted/internet/defer.py", line 609, in gotResult _deferGenerator(g, deferred) File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/twisted/internet/defer.py", line 586, in _deferGenerator deferred.callback(result) File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/twisted/internet/defer.py", line 242, in callback self._startRunCallbacks(result) File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/twisted/internet/defer.py", line 307, in _startRunCallbacks self._runCallbacks() --- <exception caught here> --- File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/twisted/internet/defer.py", line 323, in _runCallbacks self.result = callback(self.result, *args, **kw) File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/twisted/web2/resource.py", line 230, in <lambda> ).addCallback(lambda res: self.render(request)) File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/sage/server/notebook/twist.py", line 326, in render W = notebook.import_worksheet(filename, self.username) File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/sage/server/notebook/notebook.py", line 800, in import_worksheet return self._import_worksheet_sws(filename, owner) File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/sage/server/notebook/notebook.py", line 882, in _import_worksheet_sws worksheet_txt = open(text_filename).read() exceptions.IOError: [Errno 2] No such file or directory: '/home/boothby/.sage/temp/eight/32244/dir_1/pippenger/worksheet.txt'
It would be nice be able to recover this. It isn't a problem (for me) to do this manually, and this is probably irrelevant to this ticket.
comment:10 Changed 13 years ago by
- Description modified (diff)
Accidentally pasted this url to the description, not my comment:
Changed 13 years ago by
comment:11 Changed 13 years ago by
- Summary changed from [with patch; mostly positive review] notebook improvement -- upload allow txt worksheets. to [with patch; needs review] notebook improvement -- upload allow txt worksheets.
comment:12 Changed 13 years ago by
- Summary changed from [with patch; needs review] notebook improvement -- upload allow txt worksheets. to [with patch; negative review] notebook improvement -- upload allow txt worksheets.
This occurs whenever I try to upload from a URL:
2008-05-14 18:28:20-0700 [-] Unhandled Error Traceback (most recent call last): File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/twisted/internet/defer.py", line 609, in gotResult _deferGenerator(g, deferred) File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/twisted/internet/defer.py", line 586, in _deferGenerator deferred.callback(result) File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/twisted/internet/defer.py", line 242, in callback self._startRunCallbacks(result) File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/twisted/internet/defer.py", line 307, in _startRunCallbacks self._runCallbacks() --- <exception caught here> --- File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/twisted/internet/defer.py", line 323, in _runCallbacks self.result = callback(self.result, *args, **kw) File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/twisted/web2/resource.py", line 230, in <lambda> ).addCallback(lambda res: self.render(request)) File "/home/boothby/sage-3.0.2.alpha0/local/lib/python2.5/site-packages/sage/server/notebook/twist.py", line 333, in render os.unlink(filename) exceptions.UnboundLocalError: local variable 'filename' referenced before assignment
Changed 13 years ago by
comment:13 Changed 13 years ago by
- Summary changed from [with patch; negative review] notebook improvement -- upload allow txt worksheets. to [with patch; positive review] notebook improvement -- upload allow txt worksheets.
works!
comment:14 Changed 13 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged all three patches in Sage 3.0.2.alpha1