Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#6354 closed enhancement (fixed)

Advertise and improve sage -fixdoctest

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-4.3
Component: doctest coverage Keywords: fix doctests
Cc: sage-combinat, mhansen, rlm Merged in: sage-4.3.alpha0
Authors: Nicolas M. Thiéry Reviewers: Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

After this patch, sage -fixdoctest handles multiline doctests, and use the line number info of sage -t to be more robust (handles multiple doctests with the same expected output in the same file).

By the way, sage -advanced advertises sage -fixdoctest.

Attachments (1)

sage-fixdoctests-6354-nt.patch​ (3.7 KB) - added by nthiery 10 years ago.

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by nthiery

comment:1 Changed 10 years ago by mhansen

  • Authors changed from nthiery to Nicolas Thiery
  • Reviewers set to Mike Hansen
  • Summary changed from [with patch, needs review] Advertise and improve sage -fixdoctest to [with patch, positive review] Advertise and improve sage -fixdoctest

Looks good to me.

comment:2 follow-up: Changed 10 years ago by rlm

  • Merged in set to sage-4.1.alpha0
  • Resolution set to fixed
  • Status changed from new to closed

comment:3 in reply to: ↑ 2 Changed 10 years ago by nthiery

  • Authors changed from Nicolas Thiery to Nicolas M. Thiéry
  • Cc rlm added
  • Resolution fixed deleted
  • Status changed from closed to new

Replying to rlm:

Err, I don't see it in sage-4.2.1; was it somehow lost?

comment:4 follow-up: Changed 10 years ago by rlm

Sorry, it must have gotten lost during merging....

comment:5 in reply to: ↑ 4 Changed 10 years ago by nthiery

  • Milestone changed from sage-4.1 to sage-4.3
  • Status changed from new to needs_review

Replying to rlm:

Sorry, it must have gotten lost during merging....

No worry :-) I set it back to positive review so that it get merged in 4.3.

comment:6 Changed 10 years ago by nthiery

  • Status changed from needs_review to positive_review

comment:7 Changed 10 years ago by mhansen

  • Merged in changed from sage-4.1.alpha0 to sage-4.3.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 10 years ago by mvngu

  • Report Upstream set to N/A
  • Summary changed from [with patch, positive review] Advertise and improve sage -fixdoctest to Advertise and improve sage -fixdoctest
Note: See TracTickets for help on using tickets.