Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#6354 closed enhancement (fixed)

Advertise and improve sage -fixdoctest

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-4.3
Component: doctest coverage Keywords: fix doctests
Cc: sage-combinat, mhansen, rlm Merged in: sage-4.3.alpha0
Authors: Nicolas M. Thiéry Reviewers: Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description

After this patch, sage -fixdoctest handles multiline doctests, and use the line number info of sage -t to be more robust (handles multiple doctests with the same expected output in the same file).

By the way, sage -advanced advertises sage -fixdoctest.

Attachments (1)

sage-fixdoctests-6354-nt.patch (3.7 KB) - added by nthiery 14 years ago.

Download all attachments as: .zip

Change History (9)

Changed 14 years ago by nthiery

comment:1 Changed 14 years ago by mhansen

Authors: nthieryNicolas Thiery
Reviewers: Mike Hansen
Summary: [with patch, needs review] Advertise and improve sage -fixdoctest[with patch, positive review] Advertise and improve sage -fixdoctest

Looks good to me.

comment:2 Changed 14 years ago by rlm

Merged in: sage-4.1.alpha0
Resolution: fixed
Status: newclosed

comment:3 in reply to:  2 Changed 13 years ago by nthiery

Authors: Nicolas ThieryNicolas M. Thiéry
Cc: rlm added
Resolution: fixed
Status: closednew

Replying to rlm:

Err, I don't see it in sage-4.2.1; was it somehow lost?

comment:4 Changed 13 years ago by rlm

Sorry, it must have gotten lost during merging....

comment:5 in reply to:  4 Changed 13 years ago by nthiery

Milestone: sage-4.1sage-4.3
Status: newneeds_review

Replying to rlm:

Sorry, it must have gotten lost during merging....

No worry :-) I set it back to positive review so that it get merged in 4.3.

comment:6 Changed 13 years ago by nthiery

Status: needs_reviewpositive_review

comment:7 Changed 13 years ago by mhansen

Merged in: sage-4.1.alpha0sage-4.3.alpha0
Resolution: fixed
Status: positive_reviewclosed

comment:8 Changed 13 years ago by mvngu

Report Upstream: N/A
Summary: [with patch, positive review] Advertise and improve sage -fixdoctestAdvertise and improve sage -fixdoctest
Note: See TracTickets for help on using tickets.