Opened 12 years ago

Closed 7 years ago

#6334 closed defect (duplicate)

[with patch, needs work] optional doctest failure -- broken finance doctest failures

Reported by: was Owned by: cswiercz
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: optional Keywords: finance, stock
Cc: cswiercz Merged in:
Authors: Reviewers: Burcin Erocal
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

sage -t -long --optional devel/sage/sage/finance/stock.py
**********************************************************************
File "/scratch/wstein/build/sage-4.0.2.alpha3/devel/sage-main/sage/finance/stock.py", line 180:
    sage: finance.Stock('vmw').google()[:5]   # optional -- internet
Expected:
    [
     28-Nov-07 80.57 88.49 80.57 87.69    7496000,
     29-Nov-07 90.91 93.20 89.50 90.85    5497600,
     30-Nov-07 95.39 95.60 89.85 91.37    4750200,
      3-Dec-07 89.87 96.00 88.70 94.97    4401100,
      4-Dec-07 92.26 97.10 92.05 95.08    2896600
    ]
Got:
    [
     16-Jun-08 66.00 67.50 65.60 67.47    1742000,
     17-Jun-08 67.84 67.84 66.03 67.00    1196900,
     18-Jun-08 66.50 66.56 64.76 66.19    1186400,
     19-Jun-08 65.92 66.50 64.69 65.72     549200,
     20-Jun-08 65.72 65.72 63.12 63.86    1242300
    ]
**********************************************************************
1 items had failures:
   1 of   7 in __main__.example_9
***Test Failed*** 1 failures.

Attachments (3)

sage-6334.patch (15.4 KB) - added by cswiercz 12 years ago.
stock-tests.txt (8.2 KB) - added by rbeezer 12 years ago.
sage -t -optional output on stock.py
trac_6334_reviewer_edits.patch (10.2 KB) - added by rbeezer 12 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 12 years ago by cswiercz

  • Owner changed from tbd to cswiercz

Changed 12 years ago by cswiercz

comment:2 Changed 12 years ago by cswiercz

  • Cc cswiercz added
  • Keywords finance stock added
  • Summary changed from optional doctest failure -- broken finance doctest failures to [with patch, needs review] optional doctest failure -- broken finance doctest failures

I also updated stock.py's documentation for Sphinx formatting.

comment:3 Changed 12 years ago by rbeezer

  • Summary changed from [with patch, needs review] optional doctest failure -- broken finance doctest failures to [with patch, needs work] optional doctest failure -- broken finance doctest failures
  1. I still get 12 optional doctest failures, it looks like the requested dates are not being honored, but I haven't deduced a pattern to it. Full output in attached text file.
  1. Documentation can be built with a lot fewer blank lines, especially inbetween list elements. Reviewer patch illustrates this and corrects one misspelled word.
  1. I couldn't test the documentation since it doesn't seem to get pulled into the reference manual. Should it be included? If not, how should it be tested?

Changed 12 years ago by rbeezer

sage -t -optional output on stock.py

Changed 12 years ago by rbeezer

comment:4 Changed 8 years ago by burcin

  • Milestone changed from sage-5.6 to sage-duplicate/invalid/wontfix
  • Report Upstream set to N/A
  • Reviewers set to Burcin Erocal
  • Status changed from needs_work to needs_review

It looks like Minh fixed the documentation in sage/finance with trac_9218-reviewer.patch:ticket:9218.

There is also #13884 to fix the optional doctests, where Karl-Dieter posted a patch.

Shall we close this ticket as duplicate?

comment:5 Changed 7 years ago by ncohen

  • Status changed from needs_review to needs_info

comment:6 Changed 7 years ago by ncohen

  • Status changed from needs_info to positive_review

comment:7 Changed 7 years ago by vbraun

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.