Opened 13 years ago

Last modified 7 years ago

#6319 needs_work defect

[with patch, needs work] optional doctest failure -- mistake in constructions guide wrt maxima interface

Reported by: was Owned by: tbd
Priority: major Milestone: sage-6.4
Component: packages: optional Keywords:
Cc: awebb Merged in:
Authors: Reviewers: Adam Webb
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This was clearly *never* tested, since eval always returns a string (it can't return nothing).

sage -t -long --optional devel/sage/doc/en/constructions/plotting.rst
**********************************************************************
File "/scratch/wstein/build/sage-4.0.2.alpha3/devel/sage-main/doc/en/constructions/plotting.rst", line 211:
    sage: maxima.eval('plotdf(x+y,[trajectory_at,2,-0.1]); ') #optional
Expected nothing
Got:
    '1'
**********************************************************************
1 items had failures:
   1 of   4 in __main__.example_11

Attachments (1)

trac_6319.patch (957 bytes) - added by wdj 13 years ago.
applies to 4.0.2.rc1

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by wdj

applies to 4.0.2.rc1

comment:1 Changed 13 years ago by wdj

  • Summary changed from optional doctest failure -- mistake in constructions guide wrt maxima interface to [with patch, needs review] optional doctest failure -- mistake in constructions guide wrt maxima interface

Passes sage -tp 1 SAGE_ROOT/devel/sage/doc/en/constructions/. Also the builds sage -docbuild constructions html (resp., pdf) went fine.

comment:2 Changed 13 years ago by awebb

  • Reviewers set to Adam Webb
  • Summary changed from [with patch, needs review] optional doctest failure -- mistake in constructions guide wrt maxima interface to [with patch, needs work] optional doctest failure -- mistake in constructions guide wrt maxima interface

I still get an error with sage -t -long --optional devel/sage/doc/en/constructions/plotting.rst, although it is with a return value of '0' instead of '1'. It passes sage -tp 1 SAGE_ROOT/devel/sage/doc/en/constructions/ for me as well.

The odd thing is that if I try the test from the sage command line I don't get the string returned i.e. the test passes. Or is it fine if 'sage -t' fails but the documentation is correct for what happens when you actually run it?

Adam

comment:3 Changed 13 years ago by awebb

  • Cc awebb added

comment:4 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:5 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:6 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:7 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4
Note: See TracTickets for help on using tickets.