Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#6300 closed defect (fixed)

[with patch, positive review] doctest fix related to singular upgrad; needed on 32-bit OS X intel, at least (maybe all 32-bit)

Reported by: William Stein Owned by: tbd
Priority: blocker Milestone: sage-4.0.2
Component: doctest coverage Keywords:
Cc: Merged in: 4.0.2.rc1
Authors: Martin Albrecht Reviewers: William Stein
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by William Stein)

> >> File
> >> "/Users/was/build/sage-4.0.2.rc0/devel/sage/sage/libs/singular/singular.
> >>pyx ", line 501:
> >>     sage: P(2^32-1)
> >> Expected:
> >>     -1
> >> Got:
> >>     4294967295
> >
> > Is that with my the fix at
> >
> >  http://trac.sagemath.org/sage_trac/attachment/ticket/6051/singular_exp_o
> >verflow.patch
> >
> > or without? It seems (since you are using a 32-bit system) all that needs
> > to be done is to fix the doctest.
>
> No, I had not applied your patch.  However, I just did, and the above
> issue remains.

Yes, the issue remains. One should change the doctest, i.e. the behaviour we
expect now is the wrong behaviour.

Attachments (1)

trac_6300.patch (662 bytes) - added by Martin Albrecht 14 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 14 years ago by William Stein

Description: modified (diff)

Changed 14 years ago by Martin Albrecht

Attachment: trac_6300.patch added

comment:2 Changed 14 years ago by Martin Albrecht

Summary: doctest fix related to singular upgrad; needed on 32-bit OS X intel, at least (maybe all 32-bit)[with patch, needs review] doctest fix related to singular upgrad; needed on 32-bit OS X intel, at least (maybe all 32-bit)

Patch depends on hotfix at #6051.

comment:3 Changed 14 years ago by Martin Albrecht

With this patch and the hotfix from #6051 all doctests pass on sage.math FWIW.

comment:4 Changed 14 years ago by William Stein

Resolution: fixed
Status: newclosed
Summary: [with patch, needs review] doctest fix related to singular upgrad; needed on 32-bit OS X intel, at least (maybe all 32-bit)[with patch, positive review] doctest fix related to singular upgrad; needed on 32-bit OS X intel, at least (maybe all 32-bit)

merged into 4.0.2.rc1

comment:5 Changed 14 years ago by Minh Van Nguyen

Authors: Martin Albrecht
Merged in: 4.0.2.rc1
Reviewers: William Stein
Note: See TracTickets for help on using tickets.