[with patch, positive review] doctest fix related to singular upgrad; needed on 32-bit OS X intel, at least (maybe all 32-bit)
| Reported by: |
William Stein |
Owned by: |
tbd |
|
Priority:
|
blocker
|
Milestone:
|
sage-4.0.2
|
|
Component:
|
doctest coverage
|
Keywords:
|
|
|
Cc:
|
|
Merged in:
|
4.0.2.rc1
|
|
Authors:
|
Martin Albrecht
|
Reviewers:
|
William Stein
|
|
Report Upstream:
|
N/A
|
Work issues:
|
|
|
Branch:
|
|
Commit:
|
|
|
Dependencies:
|
|
Stopgaps:
|
|
> >> File
> >> "/Users/was/build/sage-4.0.2.rc0/devel/sage/sage/libs/singular/singular.
> >>pyx ", line 501:
> >> sage: P(2^32-1)
> >> Expected:
> >> -1
> >> Got:
> >> 4294967295
> >
> > Is that with my the fix at
> >
> > http://trac.sagemath.org/sage_trac/attachment/ticket/6051/singular_exp_o
> >verflow.patch
> >
> > or without? It seems (since you are using a 32-bit system) all that needs
> > to be done is to fix the doctest.
>
> No, I had not applied your patch. However, I just did, and the above
> issue remains.
Yes, the issue remains. One should change the doctest, i.e. the behaviour we
expect now is the wrong behaviour.
Change History (6)
| Description: |
modified (diff)
|
| Summary: |
doctest fix related to singular upgrad; needed on 32-bit OS X intel, at least (maybe all 32-bit) →
[with patch, needs review] doctest fix related to singular upgrad; needed on 32-bit OS X intel, at least (maybe all 32-bit)
|
| Resolution: |
→ fixed
|
| Status: |
new →
closed
|
| Summary: |
[with patch, needs review] doctest fix related to singular upgrad; needed on 32-bit OS X intel, at least (maybe all 32-bit) →
[with patch, positive review] doctest fix related to singular upgrad; needed on 32-bit OS X intel, at least (maybe all 32-bit)
|
| Authors: |
→ Martin Albrecht
|
| Merged in: |
→ 4.0.2.rc1
|
| Reviewers: |
→ William Stein
|
Patch depends on hotfix at #6051.