Opened 11 years ago

Closed 10 years ago

#6291 closed enhancement (fixed)

[with patch, positve review] Missing identity function in AbelianGroup

Reported by: jlefebvre Owned by: joyner
Priority: minor Milestone: sage-4.2
Component: group theory Keywords: AbelianGroup, identity
Cc: Merged in: sage-4.2.alpha1
Authors: Jerome Lefebvre Reviewers: Rob Beezer
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Missing identity function

AbelianGroup? patch Since we can do;

sage: G = DihedralGroup(10)
sage: G.identity()
()
sage: G = SymmetricGroup(5)
sage: G.identity()
()

I thought we should be able to do the following

sage: G = AbelianGroup([2,2])
sage: G.identity()
1

Attachments (1)

6291identityFuction.patch (1.1 KB) - added by jlefebvre 11 years ago.
The identity Function

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by jlefebvre

The identity Function

comment:1 Changed 11 years ago by jlefebvre

  • Summary changed from Missing identity function in AbelianGroup to [With Patch, Needs Review] Missing identity function in AbelianGroup

comment:2 Changed 10 years ago by rbeezer

  • Keywords identity added
  • Reviewers set to Rob Beezer
  • Summary changed from [With Patch, Needs Review] Missing identity function in AbelianGroup to [with patch, positve review] Missing identity function in AbelianGroup

Good idea.

Applies, builds, functions, docs build, passes long tests.

Positive review.

comment:3 Changed 10 years ago by jason

  • Status changed from new to needs_review

comment:4 Changed 10 years ago by jason

  • Status changed from needs_review to positive_review

comment:5 Changed 10 years ago by mhansen

  • Merged in set to sage-4.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.