Opened 11 years ago
Closed 11 years ago
#6244 closed defect (fixed)
[with patch, positive review] conjugate() in sage-4.0 is broken
Reported by: | gmhossain | Owned by: | burcin |
---|---|---|---|
Priority: | major | Milestone: | sage-4.0.2 |
Component: | symbolics | Keywords: | conjugate, pynac |
Cc: | ncalexan | Merged in: | 4.0.2.alpha0 |
Authors: | Burcin Erocal | Reviewers: | Nick Alexander |
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
1) pynac .conjugate() method returns wrong answer:
f(x) = function('f',x) f(x).conjugate() f(conjugate(x))
Above is certainly not true. For example: f(x) = I + x implies f(x).conjugate() = -I + conjugate(x) which is not equal to f(conjugate(x))
2) view() causes SIGSEGV crash
f(x) = function('f',x) g(x) = f(x).conjugate() view( g(x) ) boom!!
Attachments (1)
Change History (4)
comment:1 Changed 11 years ago by
- Milestone set to sage-4.0.2
- Owner changed from (none) to burcin
- Status changed from new to assigned
Changed 11 years ago by
comment:2 Changed 11 years ago by
- Cc ncalexan added
- Summary changed from conjugate() in sage-4.0 is broken to [with patch, needs review] conjugate() in sage-4.0 is broken
This is fixed in the new pynac package here:
http://sage.math.washington.edu/home/burcin/pynac/pynac-0.1.8.p0.spkg
Since the package also contains fixes for #6256 and #6211, the doctests should be run with those patches applied.
Besides adding doctests for the fix, the patch cleans up symbolic functions and adds correct conversions for asin, asinh, acos, acosh, and atan.
Nick, can you review this?
comment:3 Changed 11 years ago by
- Merged in set to 4.0.2.alpha0
- Resolution set to fixed
- Reviewers set to Nick Alexander
- Status changed from assigned to closed
- Summary changed from [with patch, needs review] conjugate() in sage-4.0 is broken to [with patch, positive review] conjugate() in sage-4.0 is broken
Fine by me.
I have a fix for (1) above, don't know about (2) yet. Same issue effects
.real_part()
,.imag_part()
, etc. functions.