Opened 12 years ago

Closed 12 years ago

#6233 closed defect (fixed)

[with patch; positive review] remove the explain_picklejar function, since it is self contained and its test fails on all platforms

Reported by: was Owned by: tbd
Priority: blocker Milestone: sage-4.0.1
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: William Stein Reviewers: Mike Hansen
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The doctest for explain_picklejar fails on all platforms. Thus the choice is to either remove explain_pickle entirely, fix the bug (needs cwitty), or remove that one function. This ticket removes that one function explain_picklejar until cwitty fixes it.

Attachments (1)

trac_6233.patch (8.2 KB) - added by was 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by was

comment:1 Changed 12 years ago by was

  • Summary changed from remove the explain_picklejar function, since it is self contained and its test fails on all platforms to [with patch; needs review] remove the explain_picklejar function, since it is self contained and its test fails on all platforms

comment:2 Changed 12 years ago by was

Note that I think this was merged into 4.0.1 already, over a week ago in order to get that release out.

comment:3 Changed 12 years ago by mhansen

  • Authors set to William Stein
  • Milestone changed from sage-4.0.3 to sage-4.0.1
  • Resolution set to fixed
  • Reviewers set to Mike Hansen
  • Status changed from new to closed
  • Summary changed from [with patch; needs review] remove the explain_picklejar function, since it is self contained and its test fails on all platforms to [with patch; positive review] remove the explain_picklejar function, since it is self contained and its test fails on all platforms

Yep. I believe this was.

Note: See TracTickets for help on using tickets.