Opened 14 years ago

Closed 13 years ago

#6188 closed defect (fixed)

[with new patch, positive review] Add more files in sage/rings/number_field to reference manual

Reported by: David Loeffler Owned by: David Loeffler
Priority: major Milestone: sage-4.0.2
Component: number theory Keywords: documentation
Cc: Merged in: 4.0.2.alpha0
Authors: David Loeffler Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by David Loeffler)

This patch adds the files order.py, number_field_element_quadratic.pyx, number_field_rel.py, number_field_ideal_rel.py, and unit_group.py to the reference manual, and makes the necessary ReST formatting fixes to get them to build correctly.

Attachments (2)

trac_6188.patch (124.9 KB) - added by David Loeffler 14 years ago.
patch against 4.0.1.alpha0
trac_6188_review.patch (55.2 KB) - added by John Cremona 14 years ago.
Apply after previous

Download all attachments as: .zip

Change History (7)

Changed 14 years ago by David Loeffler

Attachment: trac_6188.patch added

patch against 4.0.1.alpha0

comment:1 Changed 14 years ago by David Loeffler

Description: modified (diff)
Owner: changed from William Stein to David Loeffler
Status: newassigned

comment:2 Changed 14 years ago by John Cremona

I am half way through reviewing this and should be able to finish tomorrow.

Changed 14 years ago by John Cremona

Attachment: trac_6188_review.patch added

Apply after previous

comment:3 Changed 14 years ago by John Cremona

Summary: [with patch, needs review] Add more files in sage/rings/number_field to reference manual[with new patch, needs review] Add more files in sage/rings/number_field to reference manual

I reviewed David's patch by rebuilding the reference manual and looking through the relavant sections. I found quite a few more things needing tidying up (several in functions I wrote, so my fault), hence the second patch nearly half as large as the first.

I'm happy to OK David's contribution, but someone else (David?) should run mine. It's all docstring changes, but I did check that all tests in sage/rings/number_field still pass.

comment:4 Changed 14 years ago by David Loeffler

Summary: [with new patch, needs review] Add more files in sage/rings/number_field to reference manual[with new patch, positive review] Add more files in sage/rings/number_field to reference manual

Looks fine to me.

comment:5 Changed 13 years ago by ncalexan

Authors: David Loeffler
Merged in: 4.0.2.alpha0
Resolution: fixed
Reviewers: John Cremona
Status: assignedclosed
Note: See TracTickets for help on using tickets.