Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#6141 closed enhancement (fixed)

[with patch, positive review] simplicial complexes: change 'facets' from an attribute to a method

Reported by: jhpalmieri Owned by: jhpalmieri
Priority: minor Milestone: sage-4.0.1
Component: algebraic topology Keywords:
Cc: Merged in: 4.0.1.alpha0
Authors: John Palmieri Reviewers: David Perkinson
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

See this thread from sage-devel.

Attachments (1)

facets.patch (9.8 KB) - added by jhpalmieri 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by jhpalmieri

comment:1 Changed 10 years ago by dperkinson

  • Summary changed from [with patch, needs review] simplicial complexes: change 'facets' from an attribute to a method to [with patch, positive review] simplicial complexes: change 'facets' from an attribute to a method

The patch makes a simple change. The attribute self.facet is changed to self._facet in all files in the homology directory, and a facets() method is added. I checked the new code, ran the doctests in homology, and tried a few examples of my own. Everything was OK.

I was using Sage Version 4.0.alpha0, Release Date: 2009-05-15 under Fedora 10.

comment:2 Changed 10 years ago by mhansen

  • Resolution set to fixed
  • Status changed from new to closed

While this does represent a backwards incompatible change, I think it is better to resolve it now while the code is newer.

Merged in 4.0.1.alpha0.

comment:3 Changed 10 years ago by mvngu

  • Authors set to John Palmieri
  • Merged in set to 4.0.1.alpha0
  • Reviewers set to David Perkinson
Note: See TracTickets for help on using tickets.