Opened 11 years ago

Closed 11 years ago

#6140 closed enhancement (fixed)

[with patches and spkg, positive review] Upgrade numpy to 1.3.0

Reported by: jason Owned by: mabshoff
Priority: major Milestone: sage-4.0.2
Component: packages: standard Keywords:
Cc: Merged in: 4.0.2.alpha0
Authors: Jason Grout Reviewers: Josh Kantor
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Attachments (2)

numpy-1.3.0-update.patch (1.4 KB) - added by jason 11 years ago.
trac-6140-pt2.patch (827 bytes) - added by craigcitro 11 years ago.
apply after spkg and patch above

Download all attachments as: .zip

Change History (10)

comment:1 Changed 11 years ago by jason

This is related to #3391. Also, #4205 can likely be closed once this ticket is closed.

Changed 11 years ago by jason

comment:2 Changed 11 years ago by jason

There are a few minor doctest updates that need to be done. See above for a patch which addresses at least some of these.

When doing all doctests on 4.0.rc0, I get failures in:

The following tests failed:

        sage -t  devel/sage/sage/misc/banner.py # 5 doctests failed
        sage -t  devel/sage/sage/matrix/matrix_symbolic_dense.pyx # 3 doctests failed
        sage -t  devel/sage/sage/matrix/tests.py # 1 doctests failed
        sage -t  devel/sage/sage/rings/polynomial/polynomial_element.pyx # 2 doctests failed
        sage -t  devel/sage/sage/calculus/functions.py # 1 doctests failed
        sage -t  devel/sage/sage/plot/plot_field.py # 1 doctests failed
----------------------------------------------------------------------

However, some of these failures are from rc0, not from the numpy update. The patch above corrects the failures that I know are from the numpy updated. Please let me know if there are any other doctests that need to be updated in this ticket.

comment:3 Changed 11 years ago by jason

  • Summary changed from Upgrade numpy to 1.3.0 to [with patch and spkg, needs review] Upgrade numpy to 1.3.0

comment:4 Changed 11 years ago by jkantor

  • Summary changed from [with patch and spkg, needs review] Upgrade numpy to 1.3.0 to [with patch and spkg, positive review pending doctest fix] Upgrade numpy to 1.3.0

Everything looks good, except I get one trivial test failure. As you can see its just the difference between +0 and -0. It should probably be fixed. Positive review pending a fix of that.

sage -t "devel/sage-main/sage/rings/polynomial/polynomial_element.pyx" File "/home/jkantor/sage-4.0/devel/sage-main/sage/rings/polynomial/polynomial_element.pyx", line 4059:

sage: p.roots(ring=RR)

Expected:

[(0.000000000000000, 1)]

Got:

[(-0.000000000000000, 1)]

comment:5 Changed 11 years ago by jason

Also, #5090 might be able to be closed after this is merged.

comment:6 Changed 11 years ago by jason

  • Authors set to Jason Grout

comment:7 Changed 11 years ago by craigcitro

  • Summary changed from [with patch and spkg, positive review pending doctest fix] Upgrade numpy to 1.3.0 to [with patches and spkg, positive review] Upgrade numpy to 1.3.0

This looks good. I'm attaching a second patch for that one doctest failure.

For the record, this spkg and the two patches have been merged in 4.0.2.alpha0 -- but I want to take a few minutes and carefully close all the appropriate tickets linked in the discussion above, so I'll officially close this tomorrow.

I'm going to be bold and say that my one-character patch doesn't really need a review; if someone wants to agree that it's fine, that wouldn't be bad.

Changed 11 years ago by craigcitro

apply after spkg and patch above

comment:8 Changed 11 years ago by craigcitro

  • Merged in set to 4.0.2.alpha0
  • Resolution set to fixed
  • Reviewers set to Josh Kantor
  • Status changed from new to closed

spkg and patches merged in 4.0.2.alpha0.

Note: See TracTickets for help on using tickets.