Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#6139 closed defect (fixed)

[with patch, positive review] Fix S-Box calling when m != n

Reported by: malb Owned by: malb
Priority: major Milestone: sage-4.0.1
Component: misc Keywords: crypto, mq, sbox
Cc: mvngu Merged in: 4.0.1.rc1
Authors: Martin Albrecht Reviewers: Minh Van Nguyen
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This should work:

sage: S = mq.SBox(3, 0, 1, 3, 1, 0, 2, 2)
sage: S(0)
3
sage: S([0,0,0])
[1, 1]

reported by Sajan.S on [sage-support] (27.5.09)

Attachments (2)

sbox_call_and_rest.patch (20.7 KB) - added by malb 10 years ago.
trac_6139-reviewer.patch (2.5 KB) - added by mvngu 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by malb

comment:1 Changed 10 years ago by malb

  • Cc mvngu added

Hi Minh, can I ask you to review this?

comment:2 Changed 10 years ago by mvngu

REFEREE REPORT

Patch applies OK against sage-4.0.1.alpha0, all tests pass even with -long option. Most of the patch deals with Sphinxifying the module sage/crypto/mq/sbox.py. But the main issue is to fix the bug reported at this sage-support thread. And the patch does exactly as claimed. Positive review. I've attached a reviewer patch that fixes some trivial formatting typos.

Changed 10 years ago by mvngu

comment:3 Changed 10 years ago by mvngu

  • Summary changed from [with patch, needs review] Fix S-Box calling when m != n to [with patch, positive review] Fix S-Box calling when m != n

comment:4 Changed 10 years ago by malb

The referee patch is fine too.

comment:5 Changed 10 years ago by mhansen

  • Resolution set to fixed
  • Status changed from new to closed

Merged both patches in 4.0.1.rc1.

comment:6 Changed 10 years ago by mhansen

  • Authors set to Martin Albrecht
  • Merged in set to 4.0.1.rc1
  • Reviewers set to Minh Van Nguyen
Note: See TracTickets for help on using tickets.