Opened 9 years ago

Closed 8 years ago

Last modified 7 years ago

#6136 closed enhancement (fixed)

(Combinatorial) Free modules: cleanup, abstraction into categories, and functorial constructions

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-4.3
Component: algebra Keywords: free modules, categories, tensor, direct sum
Cc: sage-combinat Merged in: sage-4.3.alpha0
Authors: Nicolas M. Thiéry Reviewers: Florent Hivert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by ltw)

  • Deprecates CombinatorialAlgebra?
  • Abstracts some of the generic code into ModulesWithBasis?, Algebras, ...
  • Implements the functorial constructions: tensor and cartesian product
  • Stronger type checking, use UniqueRepresentation?
  • Disabled dangerous conversions (see doc of _element_constructor), strict contains
  • Naming cleanup: _term -> term, repr -> _repr_, _element_class -> element_class _combinatorial_class -> _basis_keys
  • New methods: monomial, sum_of_terms, sum_of_monomials, term_or_zero_if_none, from_vector, _repr_term, _repr_option_bracket
  • More interesting an_element, using heuristics
  • Handle non sortable objects in repr
  • Implements sage.categories.poor_man_map.PoorManMap? for maps between sets which are not modelled by parents.
  • This is used to make term and sum_of_monomial into maps, with codomain and composition.

Depends on the category patches. See http://trac.sagemath.org/sage_trac/wiki/CategoriesRoadMap.

Attachments (4)

categories-freemodule-6136-nt.patch (88.0 KB) - added by nthiery 8 years ago.
trac_6136-categories-freemodule-nt.patch (91.0 KB) - added by nthiery 8 years ago.
Adds TestSuite?.run call, and implements equality for PoorManMap?'s. Apply only this one.
trac_6136-categories-freemodule-nt.2.patch (92.5 KB) - added by hivert 8 years ago.
Last version of the file from combinat patch server.
trac_6136-categories-freemodule-nt.3.patch (92.5 KB) - added by hivert 8 years ago.
Correct version

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by nthiery

  • Description modified (diff)

Changed 8 years ago by nthiery

comment:2 Changed 8 years ago by nthiery

  • Authors set to Nicolas M. Thiéry
  • Description modified (diff)
  • Reviewers set to Florent Hivert
  • Status changed from new to needs_review

Changed 8 years ago by nthiery

Adds TestSuite?.run call, and implements equality for PoorManMap?'s. Apply only this one.

Changed 8 years ago by hivert

Last version of the file from combinat patch server.

comment:3 Changed 8 years ago by hivert

  • Status changed from needs_review to positive_review

comment:4 Changed 8 years ago by hivert

Apply only the last patch trac_6136-categories-freemodule-nt.2.patch

Note: it breaks some doctests which are corrected in #6137 (See http://sagetrac.org/sage_trac/wiki/CategoriesRoadMap)

Ready to go.

Cheers,

Florent

Changed 8 years ago by hivert

Correct version

comment:5 Changed 8 years ago by mhansen

  • Merged in set to sage-4.3.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:6 Changed 7 years ago by ltw

  • Description modified (diff)
  • Report Upstream set to N/A
Note: See TracTickets for help on using tickets.