Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#6133 closed defect (fixed)

[with patch, positive review] remove pbuild files in devel/sage

Reported by: craigcitro Owned by: craigcitro
Priority: major Milestone: sage-4.0
Component: build Keywords:
Cc: mhansen Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Three pbuild files still live in devel/sage, but are clearly out of date and need to be removed. The patch just removes all three.

Attachments (1)

trac-6133.patch (41.4 KB) - added by craigcitro 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by craigcitro

  • Cc mhansen added

comment:2 Changed 11 years ago by craigcitro

New patch -- cleans up MANIFEST.in, too.

comment:3 Changed 11 years ago by was

  • Milestone changed from sage-4.0 to sage-4.0.1
  • Summary changed from [with patch, needs review] remove pbuild files in devel/sage to [with patch, positivew review] remove pbuild files in devel/sage

No hurry, so this should go in 4.0.1. But I also read it, and it's a positive review.

comment:4 Changed 11 years ago by mhansen

  • Summary changed from [with patch, positivew review] remove pbuild files in devel/sage to [with patch, positive review] remove pbuild files in devel/sage

I get these failures when applying:

applying trac-6133.patch
unable to find 'build.py' for patching
1 out of 1 hunks FAILED -- saving rejects to file build.py.rej
unable to find 'clib.py' for patching
1 out of 1 hunks FAILED -- saving rejects to file clib.py.rej
unable to find 'sagebuild.py' for patching
1 out of 1 hunks FAILED -- saving rejects to file sagebuild.py.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
Errors during apply, please fix and refresh trac-6133.patch

Changed 11 years ago by craigcitro

comment:5 Changed 11 years ago by craigcitro

I was stupid -- the patch file had two copies of the same patch appended to one another. This works.

comment:6 Changed 11 years ago by mhansen

  • Resolution set to fixed
  • Status changed from new to closed

The new patch works.

Merged in 4.0.rc2.

comment:7 Changed 11 years ago by mhansen

  • Milestone changed from sage-4.0.1 to sage-4.0
Note: See TracTickets for help on using tickets.