#6120 closed defect (fixed)
[with patch, positive review] P(0).total_degree() should return -1 for multivariate polynomial rings
Reported by: | malb | Owned by: | malb |
---|---|---|---|
Priority: | major | Milestone: | sage-4.0.1 |
Component: | commutative algebra | Keywords: | |
Cc: | cremona, SimonKing | Merged in: | 4.0.1.alpha0 |
Authors: | Martin Albrecht | Reviewers: | Alex Ghitza |
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
but it returns 0
now.
Attachments (1)
Change History (7)
Changed 10 years ago by
comment:1 Changed 10 years ago by
- Cc cremona SimonKing added
comment:2 Changed 10 years ago by
comment:3 Changed 10 years ago by
I checked a few implementations, they all seem to agree that deg(0) == -1.
comment:4 Changed 10 years ago by
- Summary changed from [with patch, needs review] P(0).total_degree() should return -1 for multivariate polynomial rings to [with patch, positive review] P(0).total_degree() should return -1 for multivariate polynomial rings
Looks good, applies (with some fuzz) to 4.0.rc2, and passes doctests in sage/rings/polynomial.
comment:5 Changed 10 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged in 4.0.1.alpha0.
comment:6 Changed 10 years ago by
- Merged in set to 4.0.1.alpha0
- Reviewers set to Alex Ghitza
Note: See
TracTickets for help on using
tickets.
At the same time we *must* do the same for the degree of univariate polynomials! there is a degree() function in rings/polynomial/polynomial_element_generic.py which currently returns -1 for deg(0), but there may be other places too -- maybe malb knows if there are others?