Opened 10 years ago
Closed 10 years ago
#6112 closed task (fixed)
[with patch, positive review] Remove stale file sage/graphs/graph_isom.pyx
Reported by: | rlm | Owned by: | ddrake |
---|---|---|---|
Priority: | major | Milestone: | sage-4.1 |
Component: | graph theory | Keywords: | |
Cc: | Merged in: | sage-4.1.alpha0 | |
Authors: | Dan Drake | Reviewers: | Robert Miller |
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
This file has been superseded by those in sage/groups/perm_gps/partn_ref
. I think its time has come.
Attachments (2)
Change History (8)
comment:1 Changed 10 years ago by
- Milestone changed from sage-4.0 to sage-4.0.1
Changed 10 years ago by
comment:2 Changed 10 years ago by
- Owner changed from rlm to ddrake
- Status changed from new to assigned
- Summary changed from Remove stale file sage/graphs/graph_isom.pyx to [with patch, needs review] Remove stale file sage/graphs/graph_isom.pyx
comment:3 Changed 10 years ago by
- Summary changed from [with patch, needs review] Remove stale file sage/graphs/graph_isom.pyx to [with patch, needs work] Remove stale file sage/graphs/graph_isom.pyx
Wait, that was stupid...you can't just remove a file and expect things that use that file to figure out what to do...! Needs work.
comment:4 Changed 10 years ago by
I'll take care of this -- I'm currently in the middle of overhauling graphs, and this is on my list.
Changed 10 years ago by
comment:5 Changed 10 years ago by
- Reviewers set to Robert Miller
- Summary changed from [with patch, needs work] Remove stale file sage/graphs/graph_isom.pyx to [with patch, positive review] Remove stale file sage/graphs/graph_isom.pyx
After deleting graph_isom.so
and testing all of sage with -long
, all is well.
The last test will be to actually roll an alpha and make sure everything still works, although I'm guessing all should be fine.
comment:6 Changed 10 years ago by
- Merged in set to sage-4.1.alpha0
- Resolution set to fixed
- Status changed from assigned to closed
Note: See
TracTickets for help on using
tickets.
I don't know much about the graphs code, but I definitely can produce a patch which deletes a file. rlm, can you review?