Opened 10 years ago
Closed 10 years ago
#6098 closed enhancement (fixed)
[with patch, positive review] 3d bezier path plotting
Reported by: | ekirkman | Owned by: | ekirkman |
---|---|---|---|
Priority: | major | Milestone: | sage-4.1.1 |
Component: | graphics | Keywords: | |
Cc: | rlm, mhansen | Merged in: | sage-4.1.1.alpha0 |
Authors: | Emily Kirkman | Reviewers: | Robert Miller |
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Attachments (3)
Change History (9)
comment:1 Changed 10 years ago by
- Summary changed from 3d bezier path plotting to [with patch, needs review] 3d bezier path plotting
Changed 10 years ago by
comment:2 Changed 10 years ago by
- Summary changed from [with patch, needs review] 3d bezier path plotting to [with patch, positive review] 3d bezier path plotting
comment:3 Changed 10 years ago by
- Reviewers set to Robert Miller
- Summary changed from [with patch, positive review] 3d bezier path plotting to [with patch, needs work] 3d bezier path plotting
Unfortunately, against 4.0.2.alpha0:
---------------------------------------------------------------------- The following tests failed: sage -t -long devel/sage/sage/plot/plot3d/shapes2.py # 4 doctests failed sage -t -long devel/sage/sage/plot/plot3d/shapes2.py # 4 doctests failed sage -t -long devel/sage/sage/plot/bezier_path.py # 2 doctests failed ----------------------------------------------------------------------
comment:4 Changed 10 years ago by
- Summary changed from [with patch, needs work] 3d bezier path plotting to [with patch, positive review] 3d bezier path plotting
It was completely trivial to get this patch working again. I did the work while Emily watched over my shoulder. If one positive review isn't enough, then you have two! :)
comment:5 Changed 10 years ago by
Oops... ignore the patch trac_6098-reviewer.patch
. Just to let people know, only the patch trac_6098-rebased.patch
has been merged in sage-4.1.1-alpha0. I can't close this ticket because I don't have the privilege to do so. Sorry, folks :-(
comment:6 Changed 10 years ago by
- Merged in set to sage-4.1.1.alpha0
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
This picture was created with input sage: bezier3d((0,0,0),(1,0,0),(0,1,0),(0,1,1)?)