Opened 10 years ago

Closed 10 years ago

Last modified 4 years ago

#6096 closed defect (fixed)

[with patch, positive review] Fix subtle bug in partition refinement

Reported by: rlm Owned by: rlm
Priority: major Milestone: sage-4.0
Component: graph theory Keywords:
Cc: sage-combinat Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by chapoton)

This patch includes a module which gives an extremely simple example of using the partn_ref module, which exposed the bug, whose fix is:

diff -r feb2d962bf2b -r f5d696c216ff sage/groups/perm_gps/partn_ref/double_coset.pyx
--- a/sage/groups/perm_gps/partn_ref/double_coset.pyx Mon May 18 12:46:23 2009 -0700
+++ b/sage/groups/perm_gps/partn_ref/double_coset.pyx Wed May 20 14:59:09 2009 -0700
@@ -540,7 +540,7 @@
         if not possible:
             possible = 1
             i = current_ps.depth
-            current_ps.depth = min(first_kids_are_same-1, current_kids_are_same-1)
+            current_ps.depth = current_kids_are_same-1
             if i == current_kids_are_same:
                 continue # main loop
             if index_in_fp_and_mcr < len_of_fp_and_mcr - 1:

Attachments (1)

trac_6096-partition_refinement_lists.patch (7.8 KB) - added by rlm 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by rlm

The module refinement_list was written by Nicolas Borie, and I just cleaned it up a bit. He and Nicolas Thiery found the bug and reported it to me. The fix was mine.

comment:2 Changed 10 years ago by ekirkman

  • Summary changed from [with patch, needs review] Fix subtle bug in partition refinement to [with patch, positive review] Fix subtle bug in partition refinement

Good explanation of one-line fix at Allegro. Patch resolves issue and new doctest module is included. No doctest failures on 4.0alpha0.

comment:3 Changed 10 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 4.0.rc1.

Cheers,

Michael

comment:4 Changed 4 years ago by chapoton

  • Description modified (diff)
  • Report Upstream set to N/A
Note: See TracTickets for help on using tickets.