Opened 10 years ago

Closed 9 years ago

#6069 closed defect (fixed)

Make error message for nonexistent published page more informative

Reported by: khorton Owned by: somebody
Priority: blocker Milestone: sage-4.4.2
Component: notebook Keywords:
Cc: acleone, robert.marik Merged in: sagenb-0.8
Authors: Tim Dumol, Mitesh Patel Reviewers: Tim Dumol, Mitesh Patel
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

If someone attempts to access a URL for a published worksheet that no longer exists (perhaps because the URL changed when the worksheet went through a published to unpublished to published cycle), or the URL was mistyped, they get a blank page titled "Error | Sage Notebook", with no hint on what to do to resolve the problem.

If they are trying to access a published worksheet that cannot be found, it is probably useful to redirect to the page with the list of published worksheets, perhaps after showing an error message like "There is no worksheet currently available at this URL. You will be redirected to the <a href='URL of published worksheets index'>index of published worksheets</a> in 15 seconds."

This may be related to ticket 5988:

http://trac.sagemath.org/sage_trac/ticket/5988

Attachments (3)

trac_6069-missing-published-worksheet.patch (830 bytes) - added by timdumol 10 years ago.
This says that "There is no published worksheet with name '%s'" instead.
trac_6069-missing_pub_ws.2.patch (4.0 KB) - added by mpatel 10 years ago.
Redirect to pub/ after delay. Apply only this patch. sagenb repo.
trac_6069-missing_pub_ws.3.patch (6.9 KB) - added by mpatel 10 years ago.
Better titles for non-Error pages. Apply only this patch.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 10 years ago by timdumol

  • Report Upstream set to N/A
  • Summary changed from Blank notebook page when loading URL for published sheet that is AWOL to Make error message for nonexistent published page more informative

Changed 10 years ago by timdumol

This says that "There is no published worksheet with name '%s'" instead.

comment:2 Changed 10 years ago by timdumol

  • Authors set to Tim Dumol
  • Cc mpatel added
  • Status changed from new to needs_review

I think the previous message "The user 'pub' has no worksheet '%s'" was a bit confusing, but it does work. Feel free to ignore the patch and close this.

Changed 10 years ago by mpatel

Redirect to pub/ after delay. Apply only this patch. sagenb repo.

comment:3 Changed 10 years ago by mpatel

V2 is an attempt to set up redirection. It should also ensure for guest users that the error page does not include the full top bar (Settings, Log, etc.).

Feel free to make changes.

comment:4 Changed 10 years ago by mpatel

  • Cc acleone added

V2 applies cleanly to #8051 + #7784 + #5712.

Changed 10 years ago by mpatel

Better titles for non-Error pages. Apply only this patch.

comment:5 Changed 10 years ago by mpatel

V3 should

  • Fix #8234.
  • Use a title more appropriate than Error for certain non-Error pages (see the patch).
  • Make "Sign Out" redirect to "/" when require_login=False. This is better than returning a page whose header refers to a user named "None" and has a broken "Home" link!

comment:6 Changed 10 years ago by mpatel

  • Authors changed from Tim Dumol to Tim Dumol, Mitesh Patel
  • Cc robert.marik added; mpatel removed
  • Milestone changed from sage-wishlist to sage-4.3.3
  • Priority changed from major to blocker

comment:7 Changed 10 years ago by timdumol

Patel's changes look great. Anyone mind signing off mine?

comment:8 Changed 10 years ago by mpatel

  • Reviewers set to Tim Dumol, Mitesh Patel
  • Status changed from needs_review to positive_review

comment:9 Changed 9 years ago by jhpalmieri

  • Milestone changed from sage-4.4 to sage-5.0

(I'm not changing any notebook code in Sage 4.4.)

comment:10 Changed 9 years ago by timdumol

  • Merged in set to sagenb-0.8

comment:11 Changed 9 years ago by jhpalmieri

  • Milestone changed from sage-5.0 to sage-4.4.1

comment:12 Changed 9 years ago by timdumol

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.