Opened 12 years ago

Closed 12 years ago

Last modified 5 years ago

#6064 closed enhancement (fixed)

[with patch; with positive review] allow rationals in kronecker_symbol and legendre_symbol

Reported by: tornaria Owned by: tornaria
Priority: major Milestone: sage-4.0
Component: number theory Keywords:
Cc: Merged in: 4.0.rc0
Authors: Gonzalo Tornaría Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

With sage-4.0.alpha0:

sage: kronecker(2/3,7)
...
TypeError: no conversion of this rational to integer

Same for kronecker_symbol and legendre_symbol. However, it does make sense for these to be defined on rationals.

This is actually used by is_padic_square when used with rationals, and triggered by some of the new quadratic form doctests.

Attachments (1)

trac_6064.patch (1.0 KB) - added by tornaria 12 years ago.
allow rationals in kronecker_symbol and legendre_symbol

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by tornaria

  • Summary changed from allow rationals in kronecker_symbol and legendre_symbol to [with patch; needs review] allow rationals in kronecker_symbol and legendre_symbol

Note: this is needed to fix doctests in quadratic forms (#5954, #6037, #6040).

Changed 12 years ago by tornaria

allow rationals in kronecker_symbol and legendre_symbol

comment:2 Changed 12 years ago by cremona

  • Summary changed from [with patch; needs review] allow rationals in kronecker_symbol and legendre_symbol to [with patch; with positive review] allow rationals in kronecker_symbol and legendre_symbol

Joint review with #6062: applied both patches, both are fine and tests pass.

comment:3 Changed 12 years ago by mabshoff

  • Milestone set to sage-4.0
  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 4.0.rc0.

Cheers,

Michael

comment:4 Changed 12 years ago by davidloeffler

  • Authors set to Gonzalo Tornaria
  • Merged in set to 4.0.rc0
  • Reviewers set to John Cremona

comment:5 Changed 5 years ago by chapoton

  • Authors changed from Gonzalo Tornaria to Gonzalo Tornaría
  • Report Upstream set to N/A
Note: See TracTickets for help on using tickets.