Opened 12 years ago

Closed 12 years ago

#6062 closed defect (fixed)

[with patch; with positive review] QQ method is_padic_square fails when argument is python int

Reported by: tornaria Owned by: tornaria
Priority: major Milestone: sage-4.0
Component: basic arithmetic Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

With sage-4.0.alpha0:

sage: QQ(5).is_padic_square(int(2))
...
AttributeError: 'int' object has no attribute 'is_prime'

Attachments (1)

trac_6062.patch (938 bytes) - added by tornaria 12 years ago.
allow python int argument in is_padic_square

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by tornaria

allow python int argument in is_padic_square

comment:1 Changed 12 years ago by tornaria

Note: this is needed to fix doctests in quadratic forms (#5954, #6037, #6040).

comment:2 Changed 12 years ago by tornaria

Note: the added doctest requires the patch in #6064 to pass.

comment:3 Changed 12 years ago by cremona

  • Summary changed from [with patch; needs review] QQ method is_padic_square fails when argument is python int to [with patch; with positive review] QQ method is_padic_square fails when argument is python int

Joint review with #6064: applied both patches, both are fine and tests pass.

comment:4 Changed 12 years ago by mabshoff

  • Milestone set to sage-4.0
  • Resolution set to fixed
  • Status changed from new to closed

Merged iN Sage 4.0.rc0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.