Opened 12 years ago

Closed 12 years ago

#6037 closed enhancement (fixed)

[with patch; positive review] Major Upgrade to QuadraticForm Local Density Routines

Reported by: jonhanke Owned by: justin
Priority: major Milestone: sage-4.0
Component: quadratic forms Keywords:
Cc: mabshoff, wstein, tornaria Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jonhanke)

Completely rewritten and doctested Local densities routines according to a consistent interface (and algorithms) described in the attached PDF file.

Attachments (3)

Local Densities Writeup.pdf (131.0 KB) - added by jonhanke 12 years ago.
Description of the inputs and algorithms used in QF local density routines
patch-2__QF_local_densities__3.4.1.patch (105.2 KB) - added by jonhanke 12 years ago.
Local Densities Writeup.tex (18.2 KB) - added by jonhanke 12 years ago.
LaTeX file used to create the PDF writeup

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by jonhanke

Description of the inputs and algorithms used in QF local density routines

Changed 12 years ago by jonhanke

comment:1 Changed 12 years ago by jonhanke

  • Cc mabshoff wstein tornaria added
  • Description modified (diff)

Changed 12 years ago by jonhanke

LaTeX file used to create the PDF writeup

comment:2 Changed 12 years ago by tornaria

Looks nice. For the record, the following exported member functions (of QuadraticForm?) have been renamed/removed:

  • reindex_vector_from_extraction was removed
  • count_modp__by_gauss_sum was renamed to count_modp_solutions__by_Gauss_sum.
  • local_good_density_congruence_even__experimental was removed.
  • VecIncrement__deprecated was removed.
  • local_solution_type__deprecated was removed.
  • CountAllLocalTypesNaive__deprecated was removed.
  • count_local_type was renamed to count_congruence_solutions.
  • count_local_good_type was renamed to count_congruence_solutions__good_type.
  • count_local_zero_type was renamed to count_congruence_solutions__zero_type.
  • count_local_bad_type was renamed to count_congruence_solutions__bad_type.
  • count_local_bad_typeI was renamed to count_congruence_solutions__bad_type_I.
  • count_local_bad_typeII was renamed to count_congruence_solutions__bad_type_II.
  • local_good_density was removed.
  • local_zero_density was removed.
  • local_bad_density was removed.
  • local_badI_density was removed.
  • local_badII_density was removed.

I think the __deprecated and __experimental functions need no comment. For the renamed functions, though, it may be nice to add a compatibility wrapper with deprecation warning... (where and how?)

Jon, internal routines should be using names starting with an underscore (that's the python convention).

comment:3 Changed 12 years ago by tornaria

  • Summary changed from Major Upgrade to QuadraticForm Local Density Routines to [with patch; positive review] Major Upgrade to QuadraticForm Local Density Routines

comment:4 Changed 12 years ago by mabshoff

  • Milestone changed from sage-4.0.1 to sage-4.0
  • Resolution set to fixed
  • Status changed from new to closed

Merged patch-2QF_local_densities3.4.1.patch in Sage 4.0.rc0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.