Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#6029 closed defect (fixed)

[with patch, positive review] bug in floor() for python types

Reported by: robertwb Owned by: somebody
Priority: major Milestone: sage-4.0
Component: basic arithmetic Keywords:
Cc: Merged in: 4.0.rc0
Authors: Robert Bradshaw Reviewers: Mike Hansen
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mabshoff)

sage: floor(int(10^50))
100000000000000007629769841091887003294964970946560

Attachments (1)

6029-int-long-floor.patch (1.6 KB) - added by robertwb 11 years ago.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by robertwb

comment:1 Changed 11 years ago by mvngu

  • Summary changed from [with patch, needs review] bug in floor() for python types to [with patch, needs work] bug in floor() for python types

Some hunk failures:

----------------------------------------------------------------------
| Sage Version 3.4.2, Release Date: 2009-05-05                       |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
Loading Sage library. Current Mercurial branch is: 6029
sage: hg_sage.apply("/home/mvngu/patch/6029/6029-int-long-floor.patch")
cd "/scratch/mvngu/sage-3.4.2/devel/sage" && hg status
cd "/scratch/mvngu/sage-3.4.2/devel/sage" && hg status
cd "/scratch/mvngu/sage-3.4.2/devel/sage" && hg import   "/home/mvngu/patch/6029/6029-int-long-floor.patch"
applying /home/mvngu/patch/6029/6029-int-long-floor.patch
unable to find 'sage/functions/other.py' for patching
3 out of 3 hunks FAILED -- saving rejects to file sage/functions/other.py.rej
abort: patch failed to apply

comment:2 Changed 11 years ago by robertwb

  • Summary changed from [with patch, needs work] bug in floor() for python types to [with patch, needs review] bug in floor() for python types

This is to be applied on top of the pynac branch.

comment:3 Changed 10 years ago by mhansen

  • Summary changed from [with patch, needs review] bug in floor() for python types to [with patch, included in 5930] bug in floor() for python types

This is included in the patch at #5930.

comment:4 Changed 10 years ago by mabshoff

  • Description modified (diff)
  • Summary changed from [with patch, included in 5930] bug in floor() for python types to [with patch, positive review] bug in floor() for python types

comment:5 Changed 10 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 4.0.rc0.

Cheers,

Michael

comment:6 Changed 10 years ago by davidloeffler

  • Authors set to Robert Bradshaw
  • Merged in set to 4.0.rc0
  • Reviewers set to Mike Hansen
Note: See TracTickets for help on using tickets.